[Debian-ha-maintainers] Bug#499516: drbd8-utils: Do not 'invoke-rc.d drbd stop' in prerm script for action 'upgrade'

[Iustin Pop]

On Tue, Sep 01, 2009 at 10:17:11AM +0200, Uli Martens wrote:
> severity 499516 grave
> found 499516 2:8.3.2-1~bpo50+1
> found 499516 2:8.3.2-3
> thanks
> 
> Hi,
> 
> This problem just shut down all drbd resources on my secondary server and tried
> to shut down all resources on my primary server. Upgrading to the new package
> version stopped the one thing I'm using drbd for in the first place:
> redundancy.

I agree with this. Restarts of the drbd resource should not be done
automatically, only by the administrator.

> Please don't stop drbd on upgrade, and if you absolutelly must stop it, make
> sure it's started again after the upgrade.

I went and tested the current package in unstable and when reinstalling the
drbd8-utils package on the secondary, with the resource up and running,
“drbdsetup /dev/drbd0 events” on primary shows:

  gnta1:~# drbdsetup /dev/drbd0 events
  2 ST 0 { cs:Connected ro:Primary/Secondary ds:UpToDate/UpToDate r--- }
  (here the package secondary is being reinstalled)
  653 ST 0 { cs:TearDown ro:Primary/Unknown ds:UpToDate/DUnknown r--- }
  654 ST 0 { cs:Unconnected ro:Primary/Unknown ds:UpToDate/DUnknown r--- }
  655 ST 0 { cs:WFConnection ro:Primary/Unknown ds:UpToDate/DUnknown r--- }
  
and this leaves the resource without redundancy. Reinstalling the
package on the primary will even unmount a filesystem and tear down the
resource!

Attached to this email is patch against the current SVN tree that simply
disables the "stop" of the prerm for upgrades. If by any chance, an
upgrade absolutely requires the stop, IMHO this should be done
conditionally in the new packages's postinst/configure and not in the
old package.

I've verified and after a package built with the patch applied, *future*
upgrades will no longer shutdown the resources. But upgrading to this
fixed version will still do a shutdown, since the stop is in the old
version's prerm, which we can't change.

Note: the patch also has a few unrelated changes that were required to
be able to build the package on a clean checkout from the SVN repo.

regards,
iustin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drbd8.patch
Type: text/x-diff
Size: 1551 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-ha-maintainers/attachments/20091107/b0511858/attachment.patch>