[Debian-ha-maintainers] Bug#547566: drbd8-utils: Incorrect dependencies in init.d scripts

[Petter Reinholdtsen]

Package:  drbd8-utils
Version:  2:8.3.0-2
Severity: serious
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts.  The script have a hard dependency on
sshd, yet the package do not depend on openssh-server.  I suspect the
init.d script dependency should be an optional dependency instead.
Also, the file should depend on $local_fs to be sure the file systems
are properly mounted.

The problem with the hard sshd dependency is detected by piuparts,
where the package fail to install in unstable now.

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it the package will fail
to install when openssh-server is not installed.

diff -ur ../drbd8-8.3.2/scripts/drbd ../drbd8-8.3.2-pere/scripts/drbd
--- ../drbd8-8.3.2/scripts/drbd 2009-06-09 13:33:03.000000000 +0200
+++ ../drbd8-8.3.2-pere/scripts/drbd    2009-09-20 21:23:07.000000000 +0200
@@ -8,8 +8,10 @@
 #
 ### BEGIN INIT INFO
 # Provides: drbd
-# Required-Start: $network $syslog sshd
-# Required-Stop: $network $syslog sshd
+# Required-Start: $local_fs $network $syslog
+# Required-Stop:  $local_fs $network $syslog
+# Should-start:   sshd
+# Should-Stop:    sshd
 # Default-Start:  2 3 4 5
 # Default-Stop:   0 1 6
 # Short-Description:    Control drbd resources.

Happy hacking,
-- 
Petter Reinholdtsen