[Debian-ha-maintainers] [Linux-ha-dev] [patch v2 6/6] Debian: remove ldconfig from heartbeat.{postrm, postinst}

[Dejan Muhamedagic]

Hi all,

All other patches seem fine to me. Can you please push them.

Incidentally, Martin, is there a reason not to have debian
directories upstream in glue and agents?

Cheers,

Dejan

On Fri, Feb 05, 2010 at 11:22:57AM +1100, Simon Horman wrote:
> heartbeat doesn't install any shared libraries so there is no need
> to call ldconfig in these scripts.
> 
> This problem was flagged by lintian, for more information see:
> http://lintian.debian.org/tags/postinst-has-useless-call-to-ldconfig.html
> http://lintian.debian.org/tags/postrm-has-useless-call-to-ldconfig.html
> 
> Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Index: heartbeat-3.0.really.3.0.2.rc2/debian/heartbeat.postinst
> ===================================================================
> --- heartbeat-3.0.really.3.0.2.rc2.orig/debian/heartbeat.postinst	2010-02-04 10:45:02.000000000 +0900
> +++ heartbeat-3.0.really.3.0.2.rc2/debian/heartbeat.postinst	2010-02-04 10:45:28.000000000 +0900
> @@ -65,8 +65,6 @@ case "$1" in
>          fi
>  	update-rc.d heartbeat start 75 2 3 4 5 . stop 05 0 1 6 . >/dev/null || true
>  
> -	ldconfig
> -
>  	if which invoke-rc.d >/dev/null 2>&1; then
>  		invoke-rc.d heartbeat start || true
>  	else
> Index: heartbeat-3.0.really.3.0.2.rc2/debian/heartbeat.postrm
> ===================================================================
> --- heartbeat-3.0.really.3.0.2.rc2.orig/debian/heartbeat.postrm	2010-02-04 10:45:02.000000000 +0900
> +++ heartbeat-3.0.really.3.0.2.rc2/debian/heartbeat.postrm	2010-02-04 10:45:37.000000000 +0900
> @@ -20,7 +20,6 @@ set -e
>  # for details, see /usr/doc/packaging-manual/
>  
>  if [ "$1" = "remove" ]; then
> -        ldconfig
>  	update-rc.d -f heartbeat remove >/dev/null
>  	rm -f /var/lib/heartbeat/fifo
>  fi
> 
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/