[Debian-ha-maintainers] [Linux-ha-dev] [patch] low: init script: don't use -e argument to echo

[Florian Haas]

Simon,

per hg view it seems like this patch, and also the preceding upstream
patch, were applied directly to the the sid branch on alioth. That would
be suboptimal as it would mess up the changeset history, in the sense
that you'll never be able to tell apart upstream patches from debian
specific patches. Much better idea is to pull default from upstream
instead, and merge that into the sid branch.

Just my $.02.

Florian


On 03/10/2010 11:57 AM, Simon Horman wrote:
> On Wed, Mar 10, 2010 at 11:34:16AM +0100, Lars Ellenberg wrote:
>> On Wed, Mar 10, 2010 at 11:14:51AM +1100, Simon Horman wrote:
>>> The -e argument to echo does not seemed to be supported by dash
>>> and is treated as an literal.
>>>
>>> # bash -c "echo -e fish"
>>> fish
>>> # dash -c "echo -e fish"
>>> -e fish
>> Ok, pushed: changeset 12549 df7495bf8ed0
> 
> Thanks
> 
>>> The simple fix seems to be to just remove -e from invocations of echo.
>>> the echo(1) man page documents the -e option as:
>>>
>>> 	-e     enable interpretation of backslash escapes
>>>
>>> But none of the strings printed include such escape sequences.
>>>
>>> This change removes the -e from the output if the init script
>>> on systems where /bin/sh is dash:
>>>
>>> # /etc/init.d/heartbeat start
>>> Starting High-Availability services: mkdir: cannot create directory
>>> `/var/run/heartbeat': File exists
>> That should no longer happen, either,
>> there is test -d $D || mkdir $D.
>> (because -p of mkdir may not be there either)
> 
> I had a patch prepared to address that one,
> but I noticed that you had already committed a fix.
> 
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-ha-maintainers/attachments/20100310/6fa3bec9/attachment.pgp>