[Debian-ha-maintainers] Bug#707878: resource-agents: Pure-FTPd RA should create directory for pidfile

[Václav Ovsík]

Package: resource-agents
Version: 1:3.9.2-5+deb7u1
Severity: normal

Dear Maintainer,
as of Wheezy, /var/run (/run) directory is tmpfs filesystem without
persistent directories. Pure-FTPd System V init script handles this
by creating /var/run/pure-ftpd by itself early.
I was very confused by behaviour of Heartbeat with configured RA
Pure-FTPd, because pure-ftpd creates directory lately by itself, but
without pidfile! I was hunting the problem for hours :).
It was not evident to me the pidfile parent directory is missing
after machine reboot during first FTP startup. FTP daemon was started,
but Heartbeat was not know about it and tried to start it again and
again without success of course (address was used by orphaned daemon
already).

The correct behaviour is back after inserting this:

--- /usr/lib/ocf/resource.d/heartbeat/Pure-FTPd 2013-05-11 22:53:36.294700215 +0200
+++ /usr/lib/ocf/resource.d/heartbeat/Pure-FTPd~        2013-01-06 23:50:54.000000000 +0100
@@ -206,9 +206,6 @@
   exit $OCF_ERR_ARGS
 fi
 
-piddir=${OCF_RESKEY_pidfile%/*}
-[ -e "$piddir" ] || mkdir "$piddir"
-
 case $1 in
     start)     PureFTPd_start
                ;;

Thanks for your work!
Cheers
-- 
Zito

-- System Information:
Debian Release: 7.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages resource-agents depends on:
ii  cluster-glue  1.0.9+hg2665-1
ii  libc6         2.13-38
ii  libglib2.0-0  2.33.12+really2.32.4-5
ii  libnet1       1.1.4-2.1
ii  libplumb2     1.0.9+hg2665-1
ii  libplumbgpl2  1.0.9+hg2665-1
ii  python        2.7.3-4

resource-agents recommends no packages.

resource-agents suggests no packages.

-- no debconf information