[Debian-ha-maintainers] Bug#751073: redhat-cluster: Conflicting declarations of function daemon_init to cause undefined behaviour

[Michael Tautschnig]

Package: redhat-cluster
Version: 3.1.8-1.1
Usertags: goto-cc

During an analysis of all Debian packages using our research compiler tool-chain
(using tools from the cbmc package) the following error was found:

The following declaration of function daemon_init

http://sources.debian.net/src/redhat-cluster/3.1.8-1.1/cman/qdisk/main.c?hl=39#L39

shadows the fact that this function actually doesn't return a value:

http://sources.debian.net/src/redhat-cluster/3.1.8-1.1/cman/qdisk/daemon_init.c?hl=198#L197

Hence the call here will cause undefined behaviour:

http://sources.debian.net/src/redhat-cluster/3.1.8-1.1/cman/qdisk/main.c?hl=2004#L2004

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-ha-maintainers/attachments/20140610/81e00fa6/attachment.sig>