[Debian-ha-maintainers] Bug#765365: corosync: FTBFS on hurd-i386

[Svante Signell]

On Wed, 2014-10-22 at 16:48 +0200, Guillem Jover wrote:
> Hi!
> 
> On Tue, 2014-10-14 at 15:31:30 +0200, Svante Signell wrote:
> > Source: corosync
> > Version: 1.4.6-1.1
> > Severity: important
> > Tags: patch
> > User: debian-hurd at lists.debian.org
> > Usertags: hurd
> 
> > Currently corosync FTBFS for GNU/Hurd due to missing OS support. The
> > attached patch adds support for GNU/Hurd by adding a COROSYNC_GNU entry
> > in configure.ac, add COROSYNC_GNU entries in exec/totemip.c and use
> > _POSIX_PIPE_BUF as a replacement to PIPE_BUF, since that constant is not
> > defined on Hurd.
> 
> W/o having checked the actual source, with more context, it seems to
> me this is possibly problematic:
> 
> > Index: corosync-1.4.6/configure.ac
> > ===================================================================
> > --- corosync-1.4.6.orig/configure.ac
> > +++ corosync-1.4.6/configure.ac
> > @@ -342,6 +342,17 @@ case "$host_os" in
> >  		DARWIN_OPTS=""
> >  		SOLARIS_OPTS=" "
> >  	;;
> > +	*gnu*)

           gnu*) is sufficient here, since the check is on host_os!

> This catches any *gnu* system including linux-gnu, but I assume that
> was already matched upwards, as there's usage of COROSYNC_LINUX in the
> code below? Which means…

> >  #if defined(COROSYNC_LINUX)
> > -#include <net/if.h>

This is a mistake: this header include should not be removed!

> … this change would break on COROSYNC_LINUX as there COROSYNC_GNU would
> not be defined? Did you try bulding this on GNU/Linux?

I've rebuilt now on both Linux and GNU. updated patch attached

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-hurd_support.patch
Type: text/x-patch
Size: 1702 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-ha-maintainers/attachments/20141022/75e3d820/attachment-0001.bin>