[Debian-ha-maintainers] Bug#842886: sbd: FTBFS with ld --as-needed

[Logan Rosen]

Package: sbd
Version: 1.2.0-109-gc511b06-2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu zesty ubuntu-patch

Dear Maintainer,

sbd currently fails to build with ld --as-needed, which needs the linked libraries
to come after the objects that need them. LDFLAGS should only be used for linker options.

See https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries for more
information.

In Ubuntu, the attached patch was applied to achieve the following:

  * Merge from Debian unstable. Remaining changes:
    - debian/patches/ld-as-needed.patch: Use LDADD instead of LDFLAGS to fix
      FTBFS with ld --as-needed.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: stretch/sid
  APT prefers yakkety-updates
  APT policy: (500, 'yakkety-updates'), (500, 'yakkety-security'), (500, 'yakkety')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-21-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sbd_1.2.0-109-gc511b06-2ubuntu1.debdiff
Type: text/x-diff
Size: 1199 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-ha-maintainers/attachments/20161102/23a95511/attachment.diff>