[Debian-ha-maintainers] Bug#853337: booth: ftbfs with GCC-7

[Matthias Klose]

Package: src:booth
Version: 1.0-2
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/booth_1.0-2_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
  OS   defined LDFLAGS     = 
  OS   defined LDL         = -ldl
  OS   defined DYFLAGS     = -rdynamic
  ANSI defined CPPFLAGS    = 
  Coverage     CFLAGS      = 
  Coverage     LDFLAGS     = 
  Fatal War.   CFLAGS      = 
  Final        CFLAGS      = -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3 -ggdb3  	  -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wno-long-long -Wno-strict-aliasing  
  Final        CPPFLAGS    = -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/libxml2  -D_GNU_SOURCE -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include 
  Final        LDFLAGS     = -Wl,-z,relro -Wl,-z,now  
   dh_auto_build
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
GNUmakefile:41: warning: overriding recipe for target 'srpm'
Makefile:1611: warning: ignoring old recipe for target 'srpm'
GNUmakefile:46: warning: overriding recipe for target 'rpm'
Makefile:1616: warning: ignoring old recipe for target 'rpm'
Making all in src
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
make  all-am
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -DHAVE_CONFIG_H -I.  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/libxml2  -D_GNU_SOURCE -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -fPIC -Werror -funsigned-char -Wno-pointer-sign -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3 -ggdb3  	  -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wno-long-long -Wno-strict-aliasing   -c -o boothd-config.o `test -f 'config.c' || echo './'`config.c
gcc -DHAVE_CONFIG_H -I.  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/libxml2  -D_GNU_SOURCE -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -fPIC -Werror -funsigned-char -Wno-pointer-sign -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3 -ggdb3  	  -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wno-long-long -Wno-strict-aliasing   -c -o boothd-main.o `test -f 'main.c' || echo './'`main.c
gcc -DHAVE_CONFIG_H -I.  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/libxml2  -D_GNU_SOURCE -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -fPIC -Werror -funsigned-char -Wno-pointer-sign -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3 -ggdb3  	  -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wno-long-long -Wno-strict-aliasing   -c -o boothd-raft.o `test -f 'raft.c' || echo './'`raft.c
gcc -DHAVE_CONFIG_H -I.  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/libxml2  -D_GNU_SOURCE -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -fPIC -Werror -funsigned-char -Wno-pointer-sign -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3 -ggdb3  	  -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wno-long-long -Wno-strict-aliasing   -c -o boothd-ticket.o `test -f 'ticket.c' || echo './'`ticket.c
ticket.c: In function 'process_tickets':
ticket.c:518:44: error: '%s' directive output may be truncated writing between 0 and 63 bytes into a region of size 53 [-Werror=format-truncation=]
   snprintf(buff, sizeof(buff), "granted to %s",
                                            ^~
In file included from /usr/include/stdio.h:938:0,
                 from ticket.c:25:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: format output between 12 and 75 bytes into a destination of size 64
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:499: recipe for target 'boothd-ticket.o' failed
make[3]: *** [boothd-ticket.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
Makefile:317: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
Makefile:928: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j1 returned exit code 2
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2