[Debian-ha-maintainers] Bug#894630: ocfs2-tools: sometimes parallel FTBFS

[Adrian Bunk]

Source: ocfs2-tools
Version: 1.8.5-4
Severity: important
Tags: patch

db compat >= 10 defaults to parallel, and this sometimes
causes ocfs2-tools to FTBFS:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ocfs2-tools.html

...
gcc -g -O2 -fstack-protector-strong -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -pipe  -Wdate-time -D_FORTIFY_SOURCE=2  -I../include -I. -DVERSION=\"1.8.5\"  -MD -MP -MF ./.o2cluster.d -o o2cluster.o -c o2cluster.c
o2cluster.c:32:10: fatal error: o2ne_err.h: No such file or directory
 #include "o2ne_err.h"
          ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [../Postamble.make:40: o2cluster.o] Error 1
make[2]: Leaving directory '/build/1st/ocfs2-tools-1.8.5/tunefs.ocfs2'
make[2]: *** Waiting for unfinished jobs....
make[2]: Entering directory '/build/1st/ocfs2-tools-1.8.5/tunefs.ocfs2'
compile_et o2ne_err.et
...


While fixing the Makefiles would be the preferred solution,
the following to revert to the compat < 10 default of
non-parallel building is a sufficient workaround:

--- debian/rules.old	2018-04-02 15:54:05.285054237 +0000
+++ debian/rules	2018-04-02 15:54:13.285054160 +0000
@@ -4,7 +4,7 @@
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all,-format
 
 %:
-	dh $@
+	dh $@ --no-parallel
 
 override_dh_installinit:
 	mkdir -p debian/ocfs2-tools/usr/lib/ocfs2-tools