[Debian-ha-maintainers] Bug#915240: fence-agents: reproducible build (usrmerge): embeds path of ping found via PATH

[Andreas Henriksson]

Package: fence-agents
Version: 4.3.2-1
Severity: normal
Tags: patch
User: md at linux.it
Usertags: usrmerge

Dear Maintainer,

The package currently fails to build reproducibly on merged-usr vs
non-merged systems.

The problem is that ping and ping6 full paths are looked up from
PATH and embedded into a shipped file.

This can easily be fixed by passing PING_CMD, PING6_CMD and PING4_CMD
to configure as already done for PYTHON et.al.

HEADS UP: for unknown reason, the generated configure script in
this package ends up only accepting PING*_CMD values if they are
absolute paths! (Other packages configure accepts any value of their
variables as valid.)
So while I think it would be better in this package to build without
embedding full path (and instead rely on runtime  systems PATH)
it will need to be absolute for configure not to silently ignore
what you specify.

Please see attached debdiff.

Regards,
Andreas Henriksson
-------------- next part --------------
diff -Nru fence-agents-4.3.2/debian/changelog fence-agents-4.3.2/debian/changelog
--- fence-agents-4.3.2/debian/changelog	2018-11-29 16:34:08.000000000 +0100
+++ fence-agents-4.3.2/debian/changelog	2018-12-01 22:11:51.000000000 +0100
@@ -1,3 +1,11 @@
+fence-agents (4.3.2-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Pass PING{,4,6}_CMD to configure
+    - fixes reproducible build on merged-usr vs non-merged
+
+ -- Andreas Henriksson <andreas at fatal.se>  Sat, 01 Dec 2018 22:11:51 +0100
+
 fence-agents (4.3.2-1) unstable; urgency=medium
 
   * New upstream version 4.3.2
diff -Nru fence-agents-4.3.2/debian/rules fence-agents-4.3.2/debian/rules
--- fence-agents-4.3.2/debian/rules	2018-10-09 10:13:21.000000000 +0200
+++ fence-agents-4.3.2/debian/rules	2018-12-01 22:11:51.000000000 +0100
@@ -20,6 +20,9 @@
 		--bindir=/usr/bin \
 		--sbindir=/usr/sbin \
 		--libexecdir=/usr/lib/fence-agents \
+		PING_CMD=/bin/ping \
+		PING6_CMD=/bin/ping6 \
+		PING4_CMD="/bin/ping -4" \
 		PYTHON=/usr/bin/python3 \
 		SBD_PATH=/usr/sbin/sbd \
 		VGS_PATH=/sbin/vgs