[Debian-ha-maintainers] Bug#902104: [libqb] Please fix building on riscv64

[Giovanni Mascellani]

Hi,

Il 03/12/18 19:23, wferi at niif.hu ha scritto:
> Hi Giovanni,
> 
> I notice the latest build of 1.0.3-2 succeeded on riscv64, even though I
> forgot to include the prepared patch.  Is this just by random chance, or
> did anything change to fix this problem?

I am not aware of any significant change, but this kind of failures is
known to be very randomic: depending on the specific machine, on its
load and maybe its configuration, some process that might be just above
the time threshold could go below and vice versa.

For this reason, and since I do not know of any systematic change having
happened, I would recommend applying the patch anyway.

> By the way, I meant to cut the stress test length to speed up the
> builds, instead of enlarging the timeout.  Something like this:
> 
> --- a/tests/check_ipc.c
> +++ b/tests/check_ipc.c
> @@ -1003,7 +1003,7 @@ test_ipc_stress_connections(void)
>         fail_if(pid == -1);
>         sleep(1);
>  
> -       for (connections = 1; connections < 70000; connections++) {
> +       for (connections = 1; connections < 10000; connections++) {
>                 if (conn) {
>                         qb_ipcc_disconnect(conn);
>                         conn = NULL;
> 
> If action is still needed (please confirm), would this suffice?

I do not know for sure, since one has to test on the buildd nodes, but
it might very well be. I would suggest to apply your patch, which
presumably will make it easier for the test to go through even of weak
machines, and if in the future builds should fail again consider again
raising the timeout.

Thanks, Giovanni.
-- 
Giovanni Mascellani <g.mascellani at gmail.com>
Postdoc researcher - Université Libre de Bruxelles

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/debian-ha-maintainers/attachments/20181203/b05e53cd/attachment.sig>