[Debian-ha-maintainers] Bug#933398: resource-agents: ZFS resource agent contains a bashism and fails

[Koen de Jonge]

Package: resource-agents
Version: 1:4.2.0-2
Severity: important
Tags: upstream patch

Dear Maintainer,

while trying to use the ocf:heartbeat:ZFS resource from the resource-agents package on debian buster I ran in to a problem where 

In /var/log/daemon.log I got this:
 pacemaker-controld[759]:  warning: Action 3 (zfs_monitor_0) on node1 failed (target: 7 vs. rc: 0): Error

The result was that directly after the zfs pool was imported by pacemaker (i.e. the resource was started) the resource got stopped again since the monitor script did not report the HEALTH of the pool well. 

The check for health changed on 17 oct 2018 see: https://github.com/ClusterLabs/resource-agents/commit/2bdeee4b063f73b5e1804b4bec4d1ad43733a9f7#diff-2f9687bda2dc6253e000b30aaea222d9

This change, that subsequently went in to debian buster works fine in bash, but not in dash (which /bin/sh is).

I have reported the problem upstream and created a fix here: https://github.com/ClusterLabs/resource-agents/pull/1372

Can you fix this in debian stable? 

Thanks,
Koen de Jonge

-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages resource-agents depends on:
ii  cluster-glue  1.0.12-12
ii  gawk          1:4.2.1+dfsg-1
ii  libc6         2.28-10
ii  libglib2.0-0  2.58.3-2
ii  libnet1       1.1.6+dfsg-3.1
ii  libplumb2     1.0.12-12
ii  libplumbgpl2  1.0.12-12
ii  python3       3.7.3-1

Versions of packages resource-agents recommends:
ii  libxml2-utils      2.9.4+dfsg1-7+b3
ii  net-tools          1.60+git20180626.aebd88e-1
ii  python3-googleapi  1.5.5-1

resource-agents suggests no packages.

-- no debconf information