[Debian-ha-maintainers] Bug#925821: sbd: ftbfs with GCC-9

[Matthias Klose]

Package: src:sbd
Version: 1.4.0-1
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-9

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-9/g++-9, but succeeds to build with gcc-8/g++-8. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc9-20190321/sbd_1.4.0-1_unstable_gcc9.log
The last lines of the build log are at the end of this report.

To build with GCC 9, either set CC=gcc-9 CXX=g++-9 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-9/porting_to.html

GCC 9 also passes the linker option --as-needed by default; typical
build issues are passing libraries before object files to the linker,
or underlinking of convenience libraries built from the same source.

[...]
checking pacemaker/crm/cluster.h usability... yes
checking pacemaker/crm/cluster.h presence... yes
checking for pacemaker/crm/cluster.h... yes
checking for pcmk_strerror in -lcrmcommon... yes
checking for cib_apply_patch_event in -lcib... yes
checking whether pcmk_cluster_classic_ais is declared... no
checking whether pcmk_cluster_cman is declared... no
checking for pe_new_working_set... yes
checking for pod2man... /usr/bin/pod2man
/proc/{pid} is supported
checking for setproctitle... no
checking libutil.h usability... no
checking libutil.h presence... no
checking for libutil.h... no
checking for setproctitle in -lutil... no
checking sys/pstat.h usability... no
checking sys/pstat.h presence... no
checking for sys/pstat.h... no
checking whether __progname and __progname_full are available... yes
checking which argv replacement method to use... writeable
configure: Sanitizing prefix: /usr
configure: Sanitizing exec_prefix: NONE
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating agent/Makefile
config.status: creating man/Makefile
config.status: creating agent/sbd
config.status: creating src/sbd.service
config.status: creating src/sbd_remote.service
config.status: creating src/sbd.sh
config.status: creating config.h
config.status: executing depfiles commands
configure: WARNING: unrecognized options: --disable-maintainer-mode
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_build -a
	make -j4
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make  all-recursive
make[2]: Entering directory '/<<PKGBUILDDIR>>'
Making all in src
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/pacemaker -I/usr/include/heartbeat -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pacemaker  -I/usr/include/libxml2  -D_GNU_SOURCE -DCHECK_AIS -DSBINDIR=\"/usr/sbin\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/x86_64-linux-gnu/pacemaker -c -o sbd-common.o sbd-common.c
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/pacemaker -I/usr/include/heartbeat -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pacemaker  -I/usr/include/libxml2  -D_GNU_SOURCE -DCHECK_AIS -DSBINDIR=\"/usr/sbin\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/x86_64-linux-gnu/pacemaker -c -o sbd-inquisitor.o sbd-inquisitor.c
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/pacemaker -I/usr/include/heartbeat -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pacemaker  -I/usr/include/libxml2  -D_GNU_SOURCE -DCHECK_AIS -DSBINDIR=\"/usr/sbin\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/x86_64-linux-gnu/pacemaker -c -o sbd-pacemaker.o sbd-pacemaker.c
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/pacemaker -I/usr/include/heartbeat -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pacemaker  -I/usr/include/libxml2  -D_GNU_SOURCE -DCHECK_AIS -DSBINDIR=\"/usr/sbin\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/x86_64-linux-gnu/pacemaker -c -o sbd-cluster.o sbd-cluster.c
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/pacemaker -I/usr/include/heartbeat -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pacemaker  -I/usr/include/libxml2  -D_GNU_SOURCE -DCHECK_AIS -DSBINDIR=\"/usr/sbin\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/x86_64-linux-gnu/pacemaker -c -o setproctitle.o setproctitle.c
gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/pacemaker -I/usr/include/heartbeat -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wdate-time -D_FORTIFY_SOURCE=2 -Werror -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pacemaker  -I/usr/include/libxml2  -D_GNU_SOURCE -DCHECK_AIS -DSBINDIR=\"/usr/sbin\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/x86_64-linux-gnu/pacemaker -c -o sbd-md.o sbd-md.c
In file included from sbd-md.c:19:
sbd-md.c: In function 'servant':
sbd.h:190:37: error: '%s' directive argument is null [-Werror=format-overflow=]
  190 | #define cl_log(level, fmt, args...) qb_log_from_external_source( __func__, __FILE__, fmt, level, __LINE__, 0, ##args)
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sbd-md.c:1050:3: note: in expansion of macro 'cl_log'
 1050 |   cl_log(LOG_ERR, "Empty disk name %s.", diskname);
      |   ^~~~~~
sbd-md.c:1050:36: note: format string is defined here
 1050 |   cl_log(LOG_ERR, "Empty disk name %s.", diskname);
      |                                    ^~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:407: sbd-md.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:387: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:328: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j4 returned exit code 2
make: *** [debian/rules:14: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2