[Debian-ha-maintainers] Bug#990222: crmsh: Bundled vim addons cannot be enabled.

[Tim Small]

Package: crmsh
Version: 4.2.1-2
Severity: normal
Tags: patch
X-Debbugs-Cc: tim at seoss.co.uk

The vim syntax highlighting addon seems to be broken:

root at crmshtest:~# vim-addons status
# Name                     User Status  System Status
haproxy                     removed       installed
pcmk                        unavailable   unavailable


The attached patch fixes this.  Unfortunately it took me quite a while
to work out how to enable the syntax highlighting plugin in the first
place, so I wonder if it might be a good idea to either:

. break it out into a separate binary package, in the same way that e.g.
haproxy does ("vim-haproxy").

or:

. Include a README.Debian with something like the description from the
vim-haproxy package, stating that vim syntax highlighting is included in
the package, which will enable syntax highlighting of pacemaker
configuration files e.g. when using:

crm configure edit

but as-per debian policy it will need to be manually enabled
e.g. with:

vim-addons install --system-wide pcmk


Thanks!

Tim.
-------------- next part --------------
diff -Naur debian/rules ../../crmsh-4.2.1/debian/rules
--- debian/rules	2020-03-15 19:22:40.000000000 +0000
+++ ../../crmsh-4.2.1/debian/rules	2021-06-23 11:33:55.626799728 +0100
@@ -51,7 +51,7 @@
 	install -m 644 -D contrib/bash_completion.sh debian/tmp/usr/share/bash-completion/completions/crm
 # install vim plugin
 	install -m 644 -D debian/vim-pcmk.yaml debian/tmp/usr/share/vim/registry/vim-pcmk.yaml
-	install -m 644 -D contrib/pcmk-ftdetect.vim debian/tmp/usr/share/vim/addons/ftplugin/vim-pcmk.vim
+	install -m 644 -D contrib/pcmk-ftdetect.vim debian/tmp/usr/share/vim/addons/ftdetect/pcmk.vim
 	install -m 644 -D contrib/pcmk.vim debian/tmp/usr/share/vim/addons/syntax/pcmk.vim
 	rm -r debian/tmp/usr/share/doc/crmsh/contrib/
 
diff -Naur debian/vim-pcmk.yaml ../../crmsh-4.2.1/debian/vim-pcmk.yaml
--- debian/vim-pcmk.yaml	2020-03-15 19:22:40.000000000 +0000
+++ ../../crmsh-4.2.1/debian/vim-pcmk.yaml	2021-06-23 11:34:27.367392895 +0100
@@ -1,5 +1,5 @@
 addon: pcmk
 description: "The Pacemaker crmsh plugin for Vim"
 files:
-  - ftplugin/pcmk-ftdetect.vim
+  - ftdetect/pcmk.vim
   - syntax/pcmk.vim