[Debian-ha-maintainers] Bug#1043927: booth: Fails to build source after successful build

[Lucas Nussbaum]

Source: booth
Version: 1.0-283-g9d4029a-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ----------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package booth
> dpkg-buildpackage: info: source version 1.0-283-g9d4029a-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Valentin Vidic <vvidic at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in src
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> test -z "boothd" || rm -f boothd
> rm -f *.o
> rm -f *.tab.c
> rm -f alt/*.o
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f alt/.deps/.dirstamp
> rm -f alt/.dirstamp
> rm -f b_config.h stamp-h1 booth_config.h stamp-h2
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f ./.deps/boothd-attr.Po
> rm -f ./.deps/boothd-auth.Po
> rm -f ./.deps/boothd-config.Po
> rm -f ./.deps/boothd-handler.Po
> rm -f ./.deps/boothd-main.Po
> rm -f ./.deps/boothd-manual.Po
> rm -f ./.deps/boothd-pacemaker.Po
> rm -f ./.deps/boothd-raft.Po
> rm -f ./.deps/boothd-request.Po
> rm -f ./.deps/boothd-ticket.Po
> rm -f ./.deps/boothd-timer.Po
> rm -f ./.deps/boothd-transport.Po
> rm -f alt/.deps/boothd-logging_libqb.Po
> rm -f alt/.deps/boothd-nametag_libsystemd.Po
> rm -f alt/.deps/boothd-range2random_glib.Po
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> Making distclean in docs
> make[2]: Entering directory '/<<PKGBUILDDIR>>/docs'
> rm -rf  boothd.8 booth-keygen.8 geostore.8
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/docs'
> Making distclean in conf
> make[2]: Entering directory '/<<PKGBUILDDIR>>/conf'
> test -z "booth-arbitrator.service booth at .service" || rm -f booth-arbitrator.service booth at .service
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/conf'
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf test/*.pyc test/__pycache__ test/runtests.py test/boothtestenv.py cov* booth.spec
> test -z "test/runtests.py.log" || rm -f test/runtests.py.log
> test -z "booth.pc script/unit-test.py script/service-runnable" || rm -f booth.pc script/unit-test.py script/service-runnable
> test -z "test/runtests.py.trs" || rm -f test/runtests.py.trs
> test . = "." || test -z "" || rm -f 
> test -z "test-suite.log" || rm -f test-suite.log
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building booth using existing ./booth_1.0-283-g9d4029a.orig.tar.gz
> dpkg-source: info: local changes detected, the modified files are:
>  booth-1.0-283-g9d4029a/.version
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/booth_1.0-283-g9d4029a-2.diff._SuVZI
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/booth_1.0-283-g9d4029a-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.