[Debian-ha-maintainers] Bug#1044302: crmsh: Fails to build source after successful build

[Lucas Nussbaum]

Source: crmsh
Version: 4.4.1-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package crmsh
> dpkg-buildpackage: info: source version 4.4.1-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Valentin Vidic <vvidic at debian.org>
>  dpkg-source --before-build .
> dpkg-source: info: using options from crmsh-4.4.1/debian/source/options: --extend-diff-ignore=^[^/]+\.egg-info/
>  debian/rules clean
> dh clean --with python3
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> python3 setup.py clean -a
> running clean
> removing 'build/lib' (and everything under it)
> 'build/bdist.linux-x86_64' does not exist -- can't clean it
> removing 'build/scripts-3.11' (and everything under it)
> removing 'build'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    debian/rules override_dh_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_clean build/ doc/*.8 doc/*.html doc/website-v1/gen/
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>  dpkg-source -b .
> dpkg-source: info: using options from crmsh-4.4.1/debian/source/options: --extend-diff-ignore=^[^/]+\.egg-info/
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building crmsh using existing ./crmsh_4.4.1.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: executable mode 0755 of 'config.status' will not be represented in diff
> dpkg-source: info: local changes detected, the modified files are:
>  crmsh-4.4.1/Makefile
>  crmsh-4.4.1/config.log
>  crmsh-4.4.1/config.status
>  crmsh-4.4.1/crmsh.spec
>  crmsh-4.4.1/doc/website-v1/news.adoc
>  crmsh-4.4.1/etc/crm.conf
>  crmsh-4.4.1/version
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/crmsh_4.4.1-1.diff.KUSShj
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/crmsh_4.4.1-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.