[Debian-ha-maintainers] Bug#1055419: bookworm-pu: package pcs/0.11.5-1+deb12u1

[Valentin Vidic]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org at packages.debian.org
Usertags: pu
X-Debbugs-Cc: pcs at packages.debian.org
Control: affects -1 + src:pcs

[ Reason ]
Running the 'crm resource move' command results in a Python
stack trace due to missing arguments in a function call. The
bug was introduced in version 0.11.5 and fixed upstream in
0.11.6.

[ Impact ]
'crm resource move' command does not work correctly.

[ Tests ]
Package tests pass for the updated package and also manual
test confirm the move command works correctly now.

[ Risks ]
The code change is simple (adding the missing function argument),
so the risk should be low.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
Function calls to tools.get_tmp_file() are replaced with
tools.get_tmp_file(None) to avoid the error:

TypeError: get_tmp_file() missing 1 required positional argument: 'data'


diff -Nru pcs-0.11.5/debian/changelog pcs-0.11.5/debian/changelog
--- pcs-0.11.5/debian/changelog	2023-03-03 08:57:59.000000000 +0100
+++ pcs-0.11.5/debian/changelog	2023-11-05 16:27:07.000000000 +0100
@@ -1,3 +1,9 @@
+pcs (0.11.5-1+deb12u1) bookworm; urgency=medium
+
+  * d/patches: add fix for resource move (Closes: #1042893)
+
+ -- Valentin Vidic <vvidic at debian.org>  Sun, 05 Nov 2023 16:27:07 +0100
+
 pcs (0.11.5-1) unstable; urgency=medium
 
   * New upstream version 0.11.5
diff -Nru pcs-0.11.5/debian/patches/Fix-resource-move.patch pcs-0.11.5/debian/patches/Fix-resource-move.patch
--- pcs-0.11.5/debian/patches/Fix-resource-move.patch	1970-01-01 01:00:00.000000000 +0100
+++ pcs-0.11.5/debian/patches/Fix-resource-move.patch	2023-11-05 16:27:07.000000000 +0100
@@ -0,0 +1,25 @@
+--- a/pcs/lib/pacemaker/live.py
++++ b/pcs/lib/pacemaker/live.py
+@@ -384,7 +384,10 @@
+     string cib_xml -- CIB XML to simulate
+     """
+     try:
+-        with tools.get_tmp_file() as new_cib_file, tools.get_tmp_file() as transitions_file:
++        with (
++            tools.get_tmp_file(None) as new_cib_file,
++            tools.get_tmp_file(None) as transitions_file,
++        ):
+             cmd = [
+                 __exec("crm_simulate"),
+                 "--simulate",
+--- a/pcs_test/tools/custom_mock.py
++++ b/pcs_test/tools/custom_mock.py
+@@ -98,7 +98,7 @@
+         except StopIteration:
+             pass
+ 
+-    def _mock_side_effect(self, data=None, binary=False):
++    def _mock_side_effect(self, data, binary=False):
+         def _seek_callback(offset):
+             if offset != 0:
+                 raise AssertionError(
diff -Nru pcs-0.11.5/debian/patches/series pcs-0.11.5/debian/patches/series
--- pcs-0.11.5/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ pcs-0.11.5/debian/patches/series	2023-11-05 16:27:07.000000000 +0100
@@ -0,0 +1 @@
+Fix-resource-move.patch