[Debian-ha-maintainers] Bug#1102663: crmsh: crmsh's update_err failing with "NameError: name 'cibadmin_opt' is not defined"

[Michael Prokop]

Package: crmsh
Version: 4.6.1-1
Severity: important

Hi,

on the system where this bug has been observed, we seem to ran into
this as loading a configuration fails and then crmsh fails hard with
tons of such messages:

| [...]
| INFO: commit forced
| Call failed: Update does not conform to the configured schema
| ERROR: name 'cibadmin_opt' is not defined
| Traceback (most recent call last):
|   File "/usr/lib/python3/dist-packages/crmsh/main.py", line 261, in main_input_loop
|     if not context.run(inp): 
|            ~~~~~~~~~~~^^^^^
|   File "/usr/lib/python3/dist-packages/crmsh/ui_context.py", line 103, in run
|     rv = self._back_out() and rv
|          ~~~~~~~~~~~~~~^^
|   File "/usr/lib/python3/dist-packages/crmsh/ui_context.py", line 340, in _back_out
|     ok = self.up() and ok
|          ~~~~~~~^^
|   File "/usr/lib/python3/dist-packages/crmsh/ui_context.py", line 329, in up
|     ok = self.current_level().end_game(no_questions_asked=self._in_transit) is not False
|          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3/dist-packages/crmsh/ui_configure.py", line 1249, in end_game
|     ok = self._commit()
|   File "/usr/lib/python3/dist-packages/crmsh/ui_configure.py", line 925, in _commit
|     return cib_factory.commit(force=True, replace=replace)
|            ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3/dist-packages/crmsh/cibconfig.py", line 2667, in commit
|     rc = self._patch_cib(force)
|   File "/usr/lib/python3/dist-packages/crmsh/cibconfig.py", line 2755, in _patch_cib
|     logger_utils.update_err("cib", cibadmin_opts, cib_diff, rc)
|     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|   File "/usr/lib/python3/dist-packages/crmsh/log.py", line 492, in update_err
|     task = task_table.get(cibadmin_opt, "replace")
|                           ^^^^^^^^^^^^
| NameError: name 'cibadmin_opt' is not defined. Did you mean: 'cibadm_opt'?
|          
| During handling of the above exception, another exception occurred:
| [...]

Reporting this against v4.6.1-1 as that's the version where this
problem initially showed up for us. But looking into crmsh's VCS,
this bug seems to have been introduced with the upstream 4.4.0
initially.

regards
-mika-