[Debian-ha-maintainers] Bug#1095176: pcs: FTBFS in unstable: tests failures

[Lucas Nussbaum]

Source: pcs
Version: 0.11.7-2
Severity: serious

Hi

The first test failure is:

===============================================================================
Failure: test_parse_empty(TestCfgKnownHosts)
/build/reproducible-path/pcs-0.11.7/pcsd/test/test_config.rb:687:in `assert_empty_data'
/build/reproducible-path/pcs-0.11.7/pcsd/test/test_config.rb:705:in `test_parse_empty'
     702:   def test_parse_empty()
     703:     cfg = CfgKnownHosts.new('')
     704:     assert_equal([], $logger.log)
  => 705:     assert_empty_data(cfg)
     706:   end
     707:
     708:   def test_parse_whitespace()
<"{\n" +
"  \"format_version\": 1,\n" +
"  \"data_version\": 0,\n" +
"  \"known_hosts\": {\n" +
"  }\n" +
"}"> expected but was
<"{\n" +
"  \"format_version\": 1,\n" +
"  \"data_version\": 0,\n" +
"  \"known_hosts\": {}\n" +
"}">

diff:
  {
    "format_version": 1,
    "data_version": 0,
?   "known_hosts": {}
-   }
  }
===============================================================================
F

I think this is caused by ruby-json 2.9.1+dfsg-1 (uploaded today in
unstable), as downgrading ruby-json to the version in testing
(2.7.6+dfsg-1) makes pcs build fine.

However the test looks flaky: it compares JSON using its text
version, when the JSON is semantically identical but textually
different.

Lucas