[Debian-ha-maintainers] Bug#1130674: pacemaker: FTBFS with glibc 2.43 due to ISO C23 const return types

[Ural Tunaboyu]

Source: pacemaker
Version: 3.0.1-1ubuntu1
Severity: important
Tags: ftbfs upstream
X-Debbugs-Cc: ural.tunaboyu at canonical.com

Dear maintainer(s),

Our last archive rebuild against glibc 2.43 flagged this package as likely
FTBFS if rebuilt on glibc2.43, due to new C23 const qualifiers.

This will become an issue when glibc2.43 lands.

Here's a failing build log:
https://launchpadlibrarian.net/849521151/buildlog_ubuntu-resolute-amd64.pacemaker_3.0.1-1ubuntu1_BUILDING.txt.gz

libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -pthread -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/uuid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libxml2 -I/usr/include/heartbeat -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/p11-kit-1 -g -O2 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/pacemaker-3.0.1-1ubuntu1 -pthread -pthread -pthread -pthread -pthread -pthread -ggdb -fgnu89-inline -Wall -Waggregate-return -Wbad-function-cast -Wcast-align -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal -Wformat-security -Wimplicit-fallthrough -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Wno-long-long -Wno-strict-aliasing -Wpointer-arith -Wstrict-prototypes -Wwrite-strings -Wunused-but-set-variable -Wformat=2 -Wformat-nonliteral -fstack-protector-strong -fstack-clash-protection -Werror -fPIC -c actions.c -fPIC -DPIC -o .libs/libcrmcommon_la-actions.o
agents.c: In function 'crm_parse_agent_spec':
agents.c:126:11: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  126 | colon = strchr(spec, ':');
      | ^
agents.c:135:15: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  135 | colon = strchr(spec, ':');
      | ^

I've gone ahead and made an MP on salsa containing the patch for Ubuntu:
https://salsa.debian.org/ha-team/pacemaker/-/merge_requests/5

However, if you wish to apply the fix from upstream directly it can be
found at https://github.com/ClusterLabs/pacemaker/commit/12dff988989a0851b62a3b27b60632eec412b5ea

Thanks,
Ural