[Debian-ha-maintainers] Bug#1136550: pcs uses pidof but does not depend on procps

[Gioele Barabucci]

Source: pcs
Version: 0.12.2-1
Usertags: pidof-without-procps

Dear maintainer(s) of pcs,

it appears that pcs uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of pcs
  that use `pidof` at runtime;
* via the `Build-Depends:` field of pcs, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of pcs, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that pcs uses `pidof` due to the following
code snippets:

```
path: pcs_0.12.2-1/pcs_test/smoke.sh.in
pcs --version
pcs host auth localhost --debug -u ${cluster_user} -p ${cluster_user_password}
if pidof systemd | grep "\b1\b"; then
    # this command requires full system with proper init process
    pcs cluster setup ${cluster_name} localhost --debug
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci