[Debian-in-workers] fonts-gargi review
Vasudev Kamath
kamathvasudev at gmail.com
Sun Nov 25 14:59:18 UTC 2012
Hi Jishnu,
Here is review.
1. Why are you introducing patch to existing files? Upstream branch and
master branch doesn't match and hence the package does not build
2. Why are you introducing .ttf into source tarball when we are going to
build it ourself?
I would suggest you to read first the structure of a repository used by
git-buildpackage and fix the repository first and then fix the
get-orig-source target. I will review the package after you have
finished this.
1. https://honk.sigxcpu.org/piki/projects/git-buildpackage/
2. http://workaround.org/debian-git-comaintenance
--
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-in-workers/attachments/20121125/e70fc625/attachment.pgp>
More information about the Debian-in-workers
mailing list