[Debian-in-workers] RFS: fonts-sambhota-tsugring

[Krishnan. N]

Hi,

Sorry, i too missed that this was for Tsugring font and not Monlam that 
i'm currently working on.

Will fix both over the weekend and inform. Thanks again for the detailed 
feedback.


krishnan


On Wednesday 12 October 2016 02:32 PM, Pirate Praveen wrote:
> On Tuesday 11 October 2016 09:44 PM, Vasudev Kamath wrote:
>> Dear Praveen,
>>
>> Please consider reviewing package before you upload the packages to
>> Debian.
>
>> Here is a review of package
>>
>> 1. Maintainer field should list Debian Indian team as maintainer and
>>    Krishna as uploader.
>> 2. copyright puts license as GPL which is ambiguous without version but
>>    License Text refers GPL-3+.
>> 3. License filed has some other information which is not really license
>>    but some copyright information by upstream, if that should really be
>>    there it should be part of Comment field please refer Debian
>>    Copyright format document for this.
>> 4. Copyright on all files and real author of fonts are listed
>>    different!.
>> 5. There is no note on how the source was prepared (README.source), if
>>    tomorrow some other team member has to update the font how he should
>>    do it?.
>>
>>
>> @Praveen I'm especially surprised that you uploaded it right away
>> without asking for fixing the above mentioned issues!. Especially
>> copyright files are important part of Debian.
>
> I was reviewing and suggesting changes via xmpp as he was creating the
> package, but indeed I missed some points, thanks for the detailed review.
>
> Since he was referring to another font (copied the debian folder) by the
> same upstream, I thought copyright would be correct. I'll be more
> careful in future.
>
>> @Krishna please update package with my above reviews and then it
>> should be re-uploaded to Debian. And please do it as soon as possible.
>>
>
> Hope Krishnan will correct these issues soon.
>
>
>
>
> _______________________________________________
> Debian-in-workers mailing list
> Debian-in-workers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-in-workers
>

-- 
CEO
gai Technologies Pvt Ltd
Nandan Ghar, Lower Barol
VPO Dari, Dharamshala,
Himachal Pradesh - 176215
INDIA

Ph: +91 9816-088-451 (Office)