[Debian-iot-maintainers] Bug#897828: openzwave: ftbfs with GCC-8

[Matthias Klose]

Package: src:openzwave
Version: 1.5+ds-5
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/openzwave_1.5+ds-5_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
Building tinystr.o
Building tinyxmlerror.o
Building tinyxml.o
Building tinyxmlparser.o
Building hid.o
Building aeskey.o
Building aescrypt.o
Building aestab.o
Building aes_modes.o
Building Security.o
Building SensorBinary.o
Building Language.o
Building ControllerReplication.o
Building SwitchMultilevel.o
Building Color.o
Building ZWavePlusInfo.o
Building Indicator.o
Building CRC16Encap.o
Building MultiInstance.o
Building MeterPulse.o
Building DoorLockLogging.o
/<<BUILDDIR>>/openzwave-1.5+ds/cpp/src/command_classes/DoorLockLogging.cpp: In member function 'virtual bool OpenZWave::DoorLockLogging::HandleMsg(const uint8*, uint32, uint32)':
/<<BUILDDIR>>/openzwave-1.5+ds/cpp/src/command_classes/DoorLockLogging.cpp:312:15: error: passing argument 1 to restrict-qualified parameter aliases with argument 4 [-Werror=restrict]
      snprintf(usercode, sizeof(usercode), "%s %d", usercode, (int)_data[12+i]);
               ^~~~~~~~                             ~~~~~~~~
/<<BUILDDIR>>/openzwave-1.5+ds/cpp/src/command_classes/DoorLockLogging.cpp:312:43: error: '%d' directive output may be truncated writing between 1 and 3 bytes into a region of size between 0 and 253 [-Werror=format-truncation=]
      snprintf(usercode, sizeof(usercode), "%s %d", usercode, (int)_data[12+i]);
                                           ^~~~~~~
/<<BUILDDIR>>/openzwave-1.5+ds/cpp/src/command_classes/DoorLockLogging.cpp:312:43: note: directive argument in the range [0, 255]
In file included from /usr/include/stdio.h:862,
                 from /usr/include/c++/8/cstdio:42,
                 from /usr/include/c++/8/ext/string_conversions.h:43,
                 from /usr/include/c++/8/bits/basic_string.h:6361,
                 from /usr/include/c++/8/string:52,
                 from /<<BUILDDIR>>/openzwave-1.5+ds/cpp/src/command_classes/CommandClasses.h:31,
                 from /<<BUILDDIR>>/openzwave-1.5+ds/cpp/src/command_classes/DoorLockLogging.cpp:28:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:35: note: '__builtin___snprintf_chk' output between 3 and 258 bytes into a destination of size 254
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [/<<BUILDDIR>>/openzwave-1.5+ds/cpp/build/support.mk:119: /<<BUILDDIR>>/openzwave-1.5+ds/.lib/DoorLockLogging.o] Error 1
make[3]: Leaving directory '/<<BUILDDIR>>/openzwave-1.5+ds/cpp/build'
make[2]: *** [Makefile:20: all] Error 2
make[2]: Leaving directory '/<<BUILDDIR>>/openzwave-1.5+ds'
make[1]: *** [debian/rules:39: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/openzwave-1.5+ds'
make: *** [debian/rules:31: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2