[Debian-iot-maintainers] Bug#984279: openzwave: ftbfs with GCC-11

[Matthias Klose]

Package: src:openzwave
Version: 1.6.1545+ds-2
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/openzwave_1.6.1545+ds-2_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
dh_clean
	rm -f debian/debhelper-build-stamp
	rm -rf debian/.debhelper/
	rm -f -- debian/libopenzwave1.6.substvars debian/libopenzwave1.6-dev.substvars debian/libopenzwave-doc.substvars debian/openzwave.substvars debian/files
	rm -fr -- debian/libopenzwave1.6/ debian/tmp/ debian/libopenzwave1.6-dev/ debian/libopenzwave-doc/ debian/openzwave/
	find .  \( \( \
		\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
		\) -exec rm -f {} + \) -o \
		\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \)
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
	install -d /<<BUILDDIR>>/openzwave-1.6.1545\+ds/debian/.debhelper/generated/_source/home
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
echo "Build version: >1.6.1545<"
Build version: >1.6.1545<
LDFLAGS="-Wl,-z,relro -Wl,-z,now" CPPFLAGS="-Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security" VERSION_MAJ=1 VERSION_MIN=6 VERSION_REV=1545 PREFIX=/usr sysconfdir=/etc/openzwave instlibdir=/usr/lib/x86_64-linux-gnu/ make
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[3]: Entering directory '/<<PKGBUILDDIR>>/cpp/build'
Building OpenZWave Version  - 1.6.1545
Building tinyxml/tinystr.cpp
Building tinyxml/tinyxml.cpp
Building tinyxml/tinyxmlerror.cpp
Building tinyxml/tinyxmlparser.cpp
Building aes/aes_modes.c
Building aes/aescrypt.c
Building aes/aeskey.c
Building aes/aestab.c
Building src/command_classes/Alarm.cpp
Building src/command_classes/ApplicationStatus.cpp
Building src/command_classes/Association.cpp
Building src/command_classes/AssociationCommandConfiguration.cpp
/<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.cpp: In member function ‘virtual bool OpenZWave::Internal::CC::AssociationCommandConfiguration::HandleMsg(const uint8*, uint32, uint32)’:
/<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.cpp:191:85: error: ‘this’ pointer is null [-Werror=nonnull]
  191 |                                                                 group->ClearCommands(nodeIdx);
      |                                                                 ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
In file included from /<<PKGBUILDDIR>>/cpp/src/Driver.h:36,
                 from /<<PKGBUILDDIR>>/cpp/src/command_classes/CommandClass.h:36,
                 from /<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.h:31,
                 from /<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.cpp:29:
/<<PKGBUILDDIR>>/cpp/src/Group.h:138:30: note: in a call to non-static member function ‘bool OpenZWave::Group::ClearCommands(uint8, uint8)’
  138 |                         bool ClearCommands(uint8 const _nodeId, uint8 const _endPoint = 0x00);
      |                              ^~~~~~~~~~~~~
/<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.cpp:199:82: error: ‘this’ pointer is null [-Werror=nonnull]
  199 |                                                                 group->AddCommand(nodeIdx, length, start + 1);
      |                                                                 ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /<<PKGBUILDDIR>>/cpp/src/Driver.h:36,
                 from /<<PKGBUILDDIR>>/cpp/src/command_classes/CommandClass.h:36,
                 from /<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.h:31,
                 from /<<PKGBUILDDIR>>/cpp/src/command_classes/AssociationCommandConfiguration.cpp:29:
/<<PKGBUILDDIR>>/cpp/src/Group.h:139:30: note: in a call to non-static member function ‘bool OpenZWave::Group::AddCommand(uint8, uint8, const uint8*, uint8)’
  139 |                         bool AddCommand(uint8 const _nodeId, uint8 const _length, uint8 const* _data, uint8 const _endPoint = 0x00);
      |                              ^~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [/<<PKGBUILDDIR>>/cpp/build/support.mk:192: /<<PKGBUILDDIR>>/.lib/AssociationCommandConfiguration.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/cpp/build'
make[2]: *** [Makefile:23: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:41: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:33: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2