[Debian-iot-maintainers] Bug#1001356: liboauth2: FTBFS with OpenSSL 3

[Steve Langasek]

Package: liboauth2
Version: 1.4.3.2-3
Severity: serious
Tags: patch experimental
Justification: ftbfs
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu jammy ubuntu-patch

Hi Nicolas,

In Ubuntu, liboauth2 is failing to build from source because we have updated
to OpenSSL 3, and liboauth2 is incompatible:

[...]
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DPACKAGE_NAME=\"liboauth2\" -DPACKAGE_TARNAME=\"liboauth2\" -DPACKAGE_VERSION=\"1.4.3.2\" -DPACKAGE_STRING=\"liboauth2\ 1.4.3.2\" -DPACKAGE_BUGREPORT=\"hans.zandbelt at zmartzone.eu\" -DPACKAGE_URL=\"\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I.  -Wall -Werror -Iinclude -Isrc   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/x86_64-linux-gnu  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -c -o src/liboauth2_la-jose.lo `test -f 'src/jose.c' || echo './'`src/jose.c
libtool: compile:  gcc -DPACKAGE_NAME=\"liboauth2\" -DPACKAGE_TARNAME=\"liboauth2\" -DPACKAGE_VERSION=\"1.4.3.2\" "-DPACKAGE_STRING=\"liboauth2 1.4.3.2\"" -DPACKAGE_BUGREPORT=\"hans.zandbelt at zmartzone.eu\" -DPACKAGE_URL=\"\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -Wall -Werror -Iinclude -Isrc -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/x86_64-linux-gnu -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -c src/jose.c  -fPIC -DPIC -o src/.libs/liboauth2_la-jose.o
src/jose.c: In function ‘_oauth2_jose_options_jwk_set_rsa_key’:
src/jose.c:1586:9: error: ‘EVP_PKEY_get1_RSA’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
 1586 |         rsa = EVP_PKEY_get1_RSA(pkey);
      |         ^~~
In file included from src/jose.c:35:
/usr/include/openssl/evp.h:1348:16: note: declared here
 1348 | struct rsa_st *EVP_PKEY_get1_RSA(EVP_PKEY *pkey);
      |                ^~~~~~~~~~~~~~~~~
[...]

  (https://launchpad.net/ubuntu/+source/liboauth2/1.4.3.2-3build1/+build/22604274)

The attached patch adds -Wno-error=deprecated-declarations to let the
package build with OpenSSL 3.  Please consider applying this patch in Debian
as well.

OpenSSL 3 is currently in Debian experimental, and is expected to be the
version of OpenSSL shipped with the next Debian release.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru liboauth2-1.4.3.2/debian/rules liboauth2-1.4.3.2/debian/rules
--- liboauth2-1.4.3.2/debian/rules	2021-10-21 07:55:39.000000000 -0700
+++ liboauth2-1.4.3.2/debian/rules	2021-12-08 16:02:32.000000000 -0800
@@ -4,6 +4,7 @@
 #export DH_VERBOSE = 1
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export DEB_CFLAGS_MAINT_APPEND = -Wno-error=deprecated-declarations
 export C_INCLUDE_PATH=$C_INCLUDE_PATH:/usr/include/apache2/
 
 export CK_FORK=no