[Debian-iot-maintainers] Bug#1066622: radlib: FTBFS: ../src/radevents.c:185:29: error: implicit declaration of function ‘radProcessGetNotifyFD’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: radlib
Version: 2.12.0-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE   -I/usr/include -I/usr/include  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radmsgRouter.lo -MD -MP -MF .deps/radmsgRouter.Tpo -c -o radmsgRouter.lo `test -f '../src/radmsgRouter.c' || echo './'`../src/radmsgRouter.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radevents.lo -MD -MP -MF .deps/radevents.Tpo -c ../src/radevents.c  -fPIC -DPIC -o .libs/radevents.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radconffile.lo -MD -MP -MF .deps/radconffile.Tpo -c ../src/radconffile.c  -fPIC -DPIC -o .libs/radconffile.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT raddebug.lo -MD -MP -MF .deps/raddebug.Tpo -c ../src/raddebug.c  -fPIC -DPIC -o .libs/raddebug.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radbuffers.lo -MD -MP -MF .deps/radbuffers.Tpo -c ../src/radbuffers.c  -fPIC -DPIC -o .libs/radbuffers.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radmsgRouter.lo -MD -MP -MF .deps/radmsgRouter.Tpo -c ../src/radmsgRouter.c  -fPIC -DPIC -o .libs/radmsgRouter.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radlist.lo -MD -MP -MF .deps/radlist.Tpo -c ../src/radlist.c  -fPIC -DPIC -o .libs/radlist.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radcrc.lo -MD -MP -MF .deps/radcrc.Tpo -c ../src/radcrc.c  -fPIC -DPIC -o .libs/radcrc.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radmsgLog.lo -MD -MP -MF .deps/radmsgLog.Tpo -c ../src/radmsgLog.c  -fPIC -DPIC -o .libs/radmsgLog.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT raddebug.lo -MD -MP -MF .deps/raddebug.Tpo -c ../src/raddebug.c -o raddebug.o >/dev/null 2>&1
> ../src/radevents.c: In function ‘radEventsSend’:
> ../src/radevents.c:185:29: error: implicit declaration of function ‘radProcessGetNotifyFD’ [-Werror=implicit-function-declaration]
>   185 |             retVal = write (radProcessGetNotifyFD (), &cbMsg, sizeof (cbMsg));
>       |                             ^~~~~~~~~~~~~~~~~~~~~
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../h -I/usr/include -D_GNU_SOURCE -I/usr/include -I/usr/include -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -MT radcrc.lo -MD -MP -MF .deps/radcrc.Tpo -c ../src/radcrc.c -o radcrc.o >/dev/null 2>&1
> cc1: some warnings being treated as errors
> make[4]: *** [Makefile:713: radevents.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/radlib_2.12.0-6_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.