[Debian-iot-maintainers] Bug#1091812: openzwave-controlpanel: FTBFS: webserver.cpp:56:10: fatal error: tinyxml.h: No such file or directory

[Santiago Vila]

Package: src:openzwave-controlpanel
Version: 1.6~git20200306.4b8a39d-1
Severity: serious
Tags: ftbfs trixie sid

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

[ Note: This error looks that it might be some kind of Makefile bug,
  so I'm adding this paragraph as a reminder that I always offer a VM
  to reproduce it if required ].

--------------------------------------------------------------------------------
[...]
 debian/rules clean
dh clean
   dh_auto_clean
	make -j2 clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
setting variables for Linux
rm -f ozwcp *.o
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
   dh_auto_build
	make -j2 "INSTALL=install --strip-program=true"
make[1]: Entering directory '/<<PKGBUILDDIR>>'
setting variables for Linux
g++ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c -Wall -Wno-unknown-pragmas -Wno-format -Wno-format-security -I /usr/include/openzwave -I /usr/include/openzwave/command_classes -I /usr/include/openzwave/value_classes -I /usr/include/openzwave/platform -I /usr/include/openzwave/platform/unix -I /usr/include/openzwave/tinyxml -o ozwcp.o ozwcp.cpp
g++ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c -Wall -Wno-unknown-pragmas -Wno-format -Wno-format-security -I /usr/include/openzwave -I /usr/include/openzwave/command_classes -I /usr/include/openzwave/value_classes -I /usr/include/openzwave/platform -I /usr/include/openzwave/platform/unix -I /usr/include/openzwave/tinyxml -o webserver.o webserver.cpp
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
webserver.cpp:56:10: fatal error: tinyxml.h: No such file or directory
   56 | #include "tinyxml.h"
      |          ^~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:53: webserver.o] Error 1
make[1]: *** Waiting for unfinished jobs....
ozwcp.cpp: In function ‘void OnNotification(const OpenZWave::Notification*, void*)’:
ozwcp.cpp:689:104: warning: ‘uint8 OpenZWave::Notification::GetSceneId() const’ is deprecated [-Wdeprecated-declarations]
  689 |                                    id.GetIndex(), valueTypeStr(id.GetType()), _notification->GetSceneId());
      |                                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from ozwcp.cpp:51:
/usr/include/openzwave/Notification.h:232:42: note: declared here
  232 |                         DEPRECATED uint8 GetSceneId() const
      |                                          ^~~~~~~~~~
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j2 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:12: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202412/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Thanks.