[Debian-iot-maintainers] ITP: libjwt14 -- The C JSON Web Token Library +JWK +JWKS

[Nicolas Mora]

Hello,

Le 2025-02-13 à 12 h 07, Ben Collins a écrit :
> 
> I've made these changes.
> 
Thanks, another set of feedbacks:

## Source
The branch debian/unstable is not correctly synced with the tag v3.1.0, 
sbuild fails on the package check then.
I suggest to fix the branch debian/unstable to match its tag, otherwise 
the package will not be accepted by the debian package builder.
Nowadays, we must upload packages as source, not as binaries (except 
when the package is NEW but still...).

I have to manually extract the tag v3.1.0 and copy the debian/ folder to 
build the package.

## debian/changelog
Since it's a new package, the debian/changelog should have only one 
entry, and not mention the previous versions of the current libjwt package.

Also, the debian/changelog should have (Closes: #1095775)

## debian/control
The debian/control should mention yourself as uploader

Uploaders: Ben Collins <bcollins at ubuntu.com>

Also, the Build-Depends valgrind and quilt are not necessay.

## debian/libjwt14-doc.doc-base
There's a typo in debian/libjwt14-doc.doc-base:
'programmatic' instead of 'programatic'
(not my fault, lintian told me)

## debian/rules
In the debian/rules, there's an unknown option -DWITH_EXAMPLES=YES which 
makes a warning message because the option doesn't exist.

Also, there is an option WITH_MBEDTLS which is off by default. Is there 
a reason why we should not package libjwt14 with mbedtls support?

## autopkgtests
I've added autopkgtests scripts because it's good practice. The 
unit-test builds the test files, and run them against the packaged 
library files. I recommend adding autopkgtests in the packages but 
that's your call too. The attached files (control and unit-test) must be 
installed in debian/tests/

> 
> Things look "ok" with 1.9.8. Lintian definitely spews a lot of warnings
> on the manpages that did not happen with doxygen 1.13.1 (that I had on
> my system). The output looks fine, so likely acceptable for now.
> 
Nevertheless, the cmake script still has find_package(Doxygen 1.12)

I've made the patch attached (cmake.patch) to build properly but it's 
your call if you want to patch the debian package, or change the 
upstream version to 1.9.

Concerning the lintian errors, I've added a 
debian/libjwt14-doc.lintian-overrides (attached too) to silent them.

In my opinion we should silent lintian false positives to make real 
errors more visible.
What do you think?

/Nicolas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake.patch
Type: text/x-patch
Size: 390 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-iot-maintainers/attachments/20250214/37f41673/attachment.bin>
-------------- next part --------------
libjwt14-doc: groff-message
libjwt14-doc: bad-whatis-entry
-------------- next part --------------
Tests: unit-test
Depends: @, gcc, libc-dev, cmake, check, libjansson-dev, libssl-dev, gnutls-dev, pkgconf
-------------- next part --------------
#!/bin/sh

set -e

exec 2>&1

mkdir build
cd build
cmake ..
make

rm -f libjwt.so*

for lib in /usr/lib/$(dpkg-architecture -qDEB_BUILD_MULTIARCH)/libjwt*.so*; do
ln -s $lib .
done

make test