[Debian-iot-maintainers] Bug#1128735: orcania: FTBFS with glibc 2.43 due to ISO C23 const return types

[Aurelien Jarno]

Source: orcania
Version: 2.3.3-1
Severity: important
Tags: ftbfs upstream
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer(s),

orcania fails to build from source with glibc 2.43, currently in
experimental. From the build log:

| /usr/bin/cc -D_GNU_SOURCE -Dorcania_EXPORTS -I/build/reproducible-path/orcania-2.3.3/include -I/build/reproducible-path/orcania-2.3.3/build -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/orcania-2.3.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -std=gnu99 -fPIC -Wextra -Wconversion -MD -MT CMakeFiles/orcania.dir/src/orcania.c.o -MF CMakeFiles/orcania.dir/src/orcania.c.o.d -o CMakeFiles/orcania.dir/src/orcania.c.o -c /build/reproducible-path/orcania-2.3.3/src/orcania.c
| /build/reproducible-path/orcania-2.3.3/src/orcania.c: In function ‘str_replace’:
| /build/reproducible-path/orcania-2.3.3/src/orcania.c:63:7: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|    63 |   ptr = strstr(source, str_old);
|       |       ^
| /build/reproducible-path/orcania-2.3.3/src/orcania.c: In function ‘o_strstr’:
| /build/reproducible-path/orcania-2.3.3/src/orcania.c:240:12: error: return discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|   240 |     return strstr(haystack, needle);
|       |            ^~~~~~
| /build/reproducible-path/orcania-2.3.3/src/orcania.c: In function ‘o_strchr’:
| /build/reproducible-path/orcania-2.3.3/src/orcania.c:248:12: error: return discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|   248 |     return strchr(haystack, c);
|       |            ^~~~~~
| /build/reproducible-path/orcania-2.3.3/src/orcania.c: In function ‘o_strrchr’:
| /build/reproducible-path/orcania-2.3.3/src/orcania.c:272:12: error: return discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|   272 |     return strrchr(haystack, c);
|       |            ^~~~~~~
| /build/reproducible-path/orcania-2.3.3/src/orcania.c: In function ‘split_string’:
| /build/reproducible-path/orcania-2.3.3/src/orcania.c:361:11: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|   361 |     token = strstr(begin, separator);
|       |           ^
| /build/reproducible-path/orcania-2.3.3/src/orcania.c:372:13: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|   372 |       token = strstr(begin, separator);
|       |             ^
| cc1: all warnings being treated as errors
| make[4]: *** [CMakeFiles/orcania.dir/build.make:110: CMakeFiles/orcania.dir/src/orcania.c.o] Error 1
| make[4]: Leaving directory '/build/reproducible-path/orcania-2.3.3/build'
| make[3]: *** [CMakeFiles/Makefile2:96: CMakeFiles/orcania.dir/all] Error 2
| make[3]: Leaving directory '/build/reproducible-path/orcania-2.3.3/build'
| make[2]: *** [Makefile:169: all] Error 2
| make[2]: Leaving directory '/build/reproducible-path/orcania-2.3.3/build'
| dh_auto_build: error: cd build && make -j128 INSTALL="install --strip-program=true" VERBOSE=1 returned exit code 2
| make[1]: *** [debian/rules:23: override_dh_auto_build] Error 25
| make[1]: Leaving directory '/build/reproducible-path/orcania-2.3.3'
| make: *** [debian/rules:13: binary] Error 2
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2

The full build log is available here [1].

The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].

I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.

Regards
Aurelien

[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/orcania_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net