[debian-lan-devel] Bug#793624: debian-lan-config: lots of unquoted shell code

[Jonas Smedegaard]

Package: debian-lan-config
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Scanning the source package with shellcheck reveals a bunch of unquoted
variables, possibly harmless but potentially leading to "surprises" -
arguably not a security flaw but scary anyway to encourage a sysadmin to
execute such complex collection of code as root that can blow up if e.g.
a server name contains space.

I dearly recommend to scan with shellcheck, and consider add it as a
test during package build to catch also future typos.


 - Jonas

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVs9LDAAoJECx8MUbBoAEhakMQAKdd4+jC4ZEq2ZlPWL/U0eKU
3G9NL7lMomigAV/6n5Cdkmsg78hnVnc0et1QUnBBiuE8MBdUFIsWSYYbw+lUFEem
wQf2KTulO8kbBXMkwkGbQBT58qtb4nLC+o6/ccMceOAt9l1Mwg9SxDELl7Nelf1V
4xMlqRPc8w3aFGQAKuQl+7gontWWNfG1aGZ2dO9m4kZ16zAkbVHHuzxif5vNNn11
VYXJXgnCqREy+ugX1kyvPky1SVdlOVIbGTACwKL29mNVwY/mKjzklYbqgkRVFkV5
wyBVv8yHe8zyNh2r3lHDJ/QFaMTqfHZlgDHpTzS9Hmro9LB2RrFQbnckLcNp3myu
vCN2DBJ1ALfw246aWcyKmTfaeqAhzeYjxh8C8BrssJZ65SKAqpDBM+1SABfA0qxn
vk4P1cb3fMBp8IPLvGKs4V6umKXLMriD4YP6oIH/fy026OUiHTc0PJyoyh8S/Ohg
sLhGctVrH5KgxeC60AIjtyXZnounHdRDYuEszbwMLWvh7hZwxivPpyzCs3TE4mqB
W8bgHunDH7k+kW80mKG1HmE3zkC1Sc8SpuRXkUcjHLKl5xXhGqgsp3usEP2Dek51
3kJhMfn5QkVy7LuoTtdLTdwPgb11osdIb/tBJ44k0uN6aQl9JQtjcR7Vvi83XqFr
szdf4JAtA/xFwfhPZLaI
=EVhs
-----END PGP SIGNATURE-----