[med-svn] r15038 - trunk/packages/libace-perl/trunk/debian

Tue Oct 29 10:48:06 UTC 2013

Author: tille
Date: 2013-10-29 10:48:06 +0000 (Tue, 29 Oct 2013)
New Revision: 15038

Added:
   trunk/packages/libace-perl/trunk/debian/README.Debian
Modified:
   trunk/packages/libace-perl/trunk/debian/changelog
   trunk/packages/libace-perl/trunk/debian/rules
Log:
Use short dh in d/rules to profit from recent enhancements; document problem with fixed setting of build path at potentially harmless place in README.Debian


Added: trunk/packages/libace-perl/trunk/debian/README.Debian
===================================================================

--- trunk/packages/libace-perl/trunk/debian/README.Debian	                        (rev 0)
+++ trunk/packages/libace-perl/trunk/debian/README.Debian	2013-10-29 10:48:06 UTC (rev 15038)
@@ -0,0 +1,25 @@
+libace-perl for Debian
+----------------------
+
+When rebuilding the package with latest packaging standards and
+comparing with previous content it was noticed that some settings
+definitely are not sanely choosen.  Since this was also not done
+before this fact is not changed but mentioned here to enable
+tracking down potential problems quickly.  Se questionable settings
+are in the file
+
+   /usr/lib/perl5/Ace/Browser/LocalSiteDefs.pm
+
+where the build directory remains hardcoded:
+
+$SITE_DEFS = '/tmp/buildd/libace-perl-1.92/debian/libace-perl/etc/libace-perl';
+$CGI_PATH  = '/tmp/buildd/libace-perl-1.92/debian/libace-perl/usr/lib/cgi-bin';
+$HTML_PATH = '/tmp/buildd/libace-perl-1.92/debian/libace-perl/usr/share/libace-perl';
+
+Since the relevant directories are not existent inside the package this
+is most probably harmless but in case a user might happen to try the
+server features via CGI this should be reported in a potential bug
+report.
+
+
+ -- Andreas Tille <tille at debian.org>  Tue, 29 Oct 2013 11:08:14 +0100

Modified: trunk/packages/libace-perl/trunk/debian/changelog
===================================================================
--- trunk/packages/libace-perl/trunk/debian/changelog	2013-10-29 10:08:53 UTC (rev 15037)
+++ trunk/packages/libace-perl/trunk/debian/changelog	2013-10-29 10:48:06 UTC (rev 15038)
@@ -6,6 +6,9 @@
      - cme fix dpkg-control
      - debhelper 9
      - canonical Vcs fields
+  * debian/README.Debian: Remark about hard coding of build directory
+    in probably unused file.
+  * debian/rules: use short dh
 
  -- Andreas Tille <tille at debian.org>  Tue, 29 Oct 2013 11:08:14 +0100
 

Modified: trunk/packages/libace-perl/trunk/debian/rules
===================================================================
--- trunk/packages/libace-perl/trunk/debian/rules	2013-10-29 10:08:53 UTC (rev 15037)
+++ trunk/packages/libace-perl/trunk/debian/rules	2013-10-29 10:48:06 UTC (rev 15038)
@@ -1,32 +1,13 @@
 #!/usr/bin/make -f
-# This debian/rules file is provided as a template for normal perl
-# packages. It was created by Marc Brockschmidt <marc at dch-faq.de> for
-# the Debian Perl Group (http://pkg-perl.alioth.debian.org/) but may
-# be used freely wherever it is useful.
 
-# Uncomment this to turn on verbose mode.
-#export DH_VERBOSE=1
-
-# If set to a true value then MakeMaker's prompt function will
-# always return the default without waiting for user input.
-#export PERL_MM_USE_DEFAULT=1
-
 PERL   ?= /usr/bin/perl
 PACKAGE = $(shell dh_listpackages)
 TMP     = $(CURDIR)/debian/$(PACKAGE)
 
-# Allow disabling build optimisation by setting noopt in
-# $DEB_BUILD_OPTIONS
-CFLAGS = -Wall -g
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-        CFLAGS += -O0
-else
-        CFLAGS += -O2
-endif
+%:
+	dh  $@
 
-build: build-stamp
-build-stamp:
-	dh_testdir
+override_dh_auto_build:
 	# The following is pasted from an interactive session, to better understand what is echoed to Makefile.PL.
 
 	# Add commands to compile the package here
@@ -44,23 +25,18 @@
 	# Directory for the acebrowser CGI scripts (~username ok): [/usr/local/apache/cgi-bin/ace]
 	# Directory does not exist.  Shall I create it for you? [y]
 	# Directory for the acebrowser HTML files and images (~username ok): [/usr/local/apache/htdocs/ace]
-	perl -e "print qq(3\ny\n$(CURDIR)/debian/libace-perl/etc/libace-perl\ny\n$(CURDIR)/debian/libace-perl/usr/lib/cgi-bin\ny\n$(CURDIR)/debian/libace-perl/usr/share/libace-perl)" | $(PERL) Makefile.PL INSTALLDIRS=vendor
+	perl -e "print qq(3\ny\n$(CURDIR)/debian/$(PACKAGE)/etc/libace-perl\ny\n$(CURDIR)/debian/$(PACKAGE)/usr/lib/cgi-bin\ny\n$(CURDIR)/debian/$(PACKAGE)/usr/share/$(PACKAGE))" | $(PERL) Makefile.PL INSTALLDIRS=vendor
 	$(MAKE) OPTIMIZE="$(CFLAGS)" LD_RUN_PATH=""
+
+override_dh_auto_test:
 	# Disabled as they need internet access.
-	# $(MAKE) test
-	touch $@
 
-clean:
+override_dh_clean:
 	[ ! -f Makefile ] || $(MAKE) realclean
 	$(RM) --recursive docs/Ace
-	dh_clean build-stamp install-stamp .docs Ace/Browser/LocalSiteDefs.pm docs/Ace.html pod2htmd.tmp pod2htmi.tmp util/ace.pl util/install.pl
-	dh clean
+	dh_clean .docs Ace/Browser/LocalSiteDefs.pm docs/Ace.html pod2htmd.tmp pod2htmi.tmp util/ace.pl util/install.pl
 
-install: install-stamp
-install-stamp: build-stamp
-	dh_testdir
-	dh_testroot
-	dh_prep
+override_dh_auto_install:
 	# Add commands to install the package into $(TMP)
 	$(MAKE) install DESTDIR=$(TMP) PREFIX=/usr
 	mv $(TMP)/usr/bin/ace.pl $(TMP)/usr/bin/ace
@@ -68,18 +44,4 @@
 	[ ! -d $(TMP)/usr/share/perl5 ] || \
 		rmdir --ignore-fail-on-non-empty --parents --verbose \
 		$(TMP)/usr/share/perl5
-	touch $@
 
-# Build architecture-independent files here.
-binary-indep: build install
-# We have nothing to do here for an architecture-dependent package
-
-# Build architecture-dependent files here.
-binary-arch: build install
-	dh binary-arch
-
-override_dh_auto_install:
-# Do nothing (it installs ace.pl again).
-
-binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install


