[med-svn] [gwama] 01/01: Fix license issue in commandLine.cpp file

Dylan Aïssi bob.dybian-guest at moszumanska.debian.org
Thu Dec 4 08:05:42 UTC 2014


This is an automated email from the git hooks/post-receive script.

bob.dybian-guest pushed a commit to branch master
in repository gwama.

commit 84e8024b63b923aca15cb6dbf0d170f498c9200c
Author: Dylan Aïssi <bob.dybian at gmail.com>
Date:   Thu Dec 4 09:04:56 2014 +0100

    Fix license issue in commandLine.cpp file
---
 debian/README.Debian                               | 81 ++++++++++++++++++++++
 debian/changelog                                   |  2 +-
 ..._Makefile_Add_FLAGS_to_activate_Hardening.patch |  1 -
 debian/patches/02_Fix_license_issue.patch          | 16 +++++
 debian/patches/series                              |  1 +
 5 files changed, 99 insertions(+), 2 deletions(-)

diff --git a/debian/README.Debian b/debian/README.Debian
new file mode 100644
index 0000000..92dcaa9
--- /dev/null
+++ b/debian/README.Debian
@@ -0,0 +1,81 @@
+GWAMA for Debian
+============================================
+About license issue in GWAMA sources.
+
+-----------------
+Date: Thu, 4 Dec 2014 07:10:56 +0100
+From: Dylan <bob.dybian at gmail.com>
+To: <amorris at well.ox.ac.uk>
+
+Dear Andrew P. Morris,
+
+I am involved in Debian Med project which provide a GNU/Linux
+distribution for biomedical research. I am making a package of GWAMA
+for integration in official Debian repository, but some points need to be
+clarify to push GWAMA in Debian.
+
+The first point is in your paper you said that GWAMA was released under BSD
+license, but you didn't precise which BSD license. I suppose it is
+BSD-3-clause license, could you please confirm it?
+
+The second point to clarify is in the file "commandLine.cpp" at line 57, it
+says "GNU General Public License, v2", could you please confirm that it is
+a mistake and you want to refer to the BSD license from the first point?
+
+Best regards,
+Dylan
+-----------------
+Date: Thu, 04 Dec 2014 08:41:55 +0200
+From: Reedik Magi <reedikm at gmail.com>
+To: <bob.dybian at gmail.com>
+CC: Andrew Morris <amorris at well.ox.ac.uk>
+
+Dear Dylan,
+
+We are mainly research oriented and actually have very little knowledge
+about pros and cons of different licence types - but yes BSD-3 clause seems
+to be appropriate. GNU licence, which is written into the log file is an
+error and will be fixed in new release.
+
+Best wishes,
+Reedik
+
+NB. GWAMA source files contain files from ALGLIB project, which have
+different copyright clauses (e.g. file normaldistr.cpp) but seem to be very
+similar to BSD-3 clause.
+-----------------
+Date: Thu, 4 Dec 2014 08:25:42 +0100
+From: Dylan <bob.dybian at gmail.com>
+To: Reedik Magi <reedikm at gmail.com>
+Cc: Andrew Morris <amorris at well.ox.ac.uk>
+
+Dear Reedik,
+Thank you for your response.
+
+As you can see the copyright file in debian folder [1] contains all
+copyright of GWAMA files and already takes account of ALGLIB copyright.
+
+If you agree, I will patch the commandLine.cpp file in debian package to
+make reference to BSD-3 clause. Could I copy your previous mail to a file
+in debian package for more transparency about these previous issues ?
+
+Best regards,
+Dylan
+
+[1]
+http://anonscm.debian.org/cgit/debian-med/gwama.git/tree/debian/copyright
+-----------------
+Date: Thu, 04 Dec 2014 09:30:34 +0200
+From: Reedik Magi <reedikm at gmail.com>
+To: Dylan <bob.dybian at gmail.com>
+CC: Andrew Morris <amorris at well.ox.ac.uk>
+
+Dear Dylan,
+
+Yes - feel free to do that!
+
+Best wishes,
+Reedik
+-----------------
+
+ -- Dylan Aïssi <bob.dybian at gmail.com>  Thu, 04 Dec 2014 08:55:35 +0100
diff --git a/debian/changelog b/debian/changelog
index fa36213..372413d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-gwama (2.1+dfsg-1) UNRELEASED; urgency=low
+gwama (2.1+dfsg-1) unstable; urgency=low
 
   * Initial Debian Release. (Closes: #770143)
 
diff --git a/debian/patches/01_Makefile_Add_FLAGS_to_activate_Hardening.patch b/debian/patches/01_Makefile_Add_FLAGS_to_activate_Hardening.patch
index d848147..685685e 100644
--- a/debian/patches/01_Makefile_Add_FLAGS_to_activate_Hardening.patch
+++ b/debian/patches/01_Makefile_Add_FLAGS_to_activate_Hardening.patch
@@ -12,4 +12,3 @@ Last-Update: 2014-11-19
 -	g++ main.cpp marker.cpp statistics.cpp study.cpp chisquaredistr.cpp normaldistr.cpp gammaf.cpp igammaf.cpp ap.cpp global.cpp problem.cpp tools.cpp cohort.cpp commandLine.cpp readFile.cpp $(DEBUGFLAGS) -o GWAMA
 +	g++ $(CXXFLAGS) $(CPPFLAGS) $(LDFLAGS) main.cpp marker.cpp statistics.cpp study.cpp chisquaredistr.cpp normaldistr.cpp gammaf.cpp igammaf.cpp ap.cpp global.cpp problem.cpp tools.cpp cohort.cpp commandLine.cpp readFile.cpp $(DEBUGFLAGS) -o GWAMA
  
-
diff --git a/debian/patches/02_Fix_license_issue.patch b/debian/patches/02_Fix_license_issue.patch
new file mode 100644
index 0000000..52dbe56
--- /dev/null
+++ b/debian/patches/02_Fix_license_issue.patch
@@ -0,0 +1,16 @@
+Author: Dylan Aïssi <bob.dybian at gmail.com>
+Description: Fix license issue in commandLine.cpp, for more information see README.Debian file.
+Forwarded: Yes
+Last-Update: 2014-12-04
+
+--- a/commandLine.cpp
++++ b/commandLine.cpp
+@@ -54,7 +54,7 @@
+    cout << "|      GWAMA        |" << v << "|    May, 2010       |" << endl;
+    cout << "|----------------------------------------------------------|" << endl;
+    cout << "|           (C) 2008 Reedik Magi & Andrew P Morris         |" << endl;
+-   cout << "|               GNU General Public License, v2             |" << endl;
++   cout << "|                   BSD-3-clause License                   |" << endl;
+    cout << "|----------------------------------------------------------|" << endl;
+    cout << "|  For documentation, citation & bug-report instructions:  |" << endl;
+    cout << "|              http://www.well.ox.ac.uk/GWAMA/             |" << endl;
diff --git a/debian/patches/series b/debian/patches/series
index d130fac..8860c59 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 01_Makefile_Add_FLAGS_to_activate_Hardening.patch
+02_Fix_license_issue.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-med/gwama.git



More information about the debian-med-commit mailing list