[med-svn] [gbrowse] 04/12: Add $remote_fs to required-start

[Andreas Tille]

This is an automated email from the git hooks/post-receive script.

tille pushed a commit to branch master
in repository gbrowse.

commit 304189b9f5dfc524d1fc4613db6b250482823a6f
Author: Andreas Tille <tille at debian.org>
Date:   Wed Jan 18 14:50:11 2017 +0100

    Add $remote_fs to required-start
---
 debian/changelog                            |  3 ++-
 debian/patches/init_script_dependency.patch | 29 +++++++++++++++++++++++++++++
 debian/patches/series                       |  1 +
 3 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 8f59dfc..b61e379 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -17,8 +17,9 @@ gbrowse (2.56+dfsg-1) UNRELEASED; urgency=medium
   * Enhance descriptions
   * hardening=+all
   * Remove unused lintian override
+  * Add $remote_fs to required-start
 
- -- Andreas Tille <tille at debian.org>  Wed, 14 Dec 2016 14:48:02 +0100
+ -- Andreas Tille <tille at debian.org>  Wed, 18 Jan 2017 14:42:04 +0100
 
 gbrowse (2.54+dfsg-7) unstable; urgency=medium
 
diff --git a/debian/patches/init_script_dependency.patch b/debian/patches/init_script_dependency.patch
new file mode 100644
index 0000000..5fc38e8
--- /dev/null
+++ b/debian/patches/init_script_dependency.patch
@@ -0,0 +1,29 @@
+Author: Andreas Tille <tille at debian.org>
+Last-Update: Wed, 18 Jan 2017 14:42:04 +0100
+Description: Add $remote_fs to required-start
+    The given init script seems to refer to /usr, possibly using a file or
+    binary from there. Without a dependency on $remote_fs in Required-Start
+    or Required-Stop, as appropriate, the init script might be run before
+    /usr is mounted or after it's unmounted.
+ .
+    Using Should-Start or Should-Stop to declare the dependency is
+    conceptually incorrect since the $remote_fs facility is always
+    available. Required-Start or Required-Stop should be used instead. Also,
+    please note that $all should not be used in Required-Stop, only
+    Required-Start.
+ .
+    Refer to https://wiki.debian.org/LSBInitScripts for details.
+
+--- a/etc/init.d/gbrowse-aws-balancer
++++ b/etc/init.d/gbrowse-aws-balancer
+@@ -1,8 +1,8 @@
+ #!/bin/sh
+ ### BEGIN INIT INFO
+ # Provides:          gbrowse_aws_balancer
+-# Required-Start:    $local_fs
+-# Required-Stop:     $local_fs
++# Required-Start:    $local_fs $remote_fs
++# Required-Stop:     $local_fs $remote_fs
+ # Default-Start:     28
+ # Default-Stop:      S
+ # Short-Description: Start/Stop the gbrowse Amazon Web Services-based slave rendering farm
diff --git a/debian/patches/series b/debian/patches/series
index 1806e95..8f657cc 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,3 +4,4 @@ manpages.patch
 fix_pop_url
 skip_check_installed_test.patch
 source_init_functions
+init_script_dependency.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-med/gbrowse.git