[med-svn] [Git][med-team/libxdf][master] 10 commits: New upstream version 0.99.6+dfsg

Andreas Tille gitlab at salsa.debian.org
Fri Dec 18 18:02:17 GMT 2020



Andreas Tille pushed to branch master at Debian Med / libxdf


Commits:
debd3a43 by Andreas Tille at 2020-12-18T16:56:00+01:00
New upstream version 0.99.6+dfsg
- - - - -
20377b95 by Andreas Tille at 2020-12-18T16:56:00+01:00
routine-update: New upstream version

- - - - -
325d2e3b by Andreas Tille at 2020-12-18T16:56:01+01:00
Update upstream source from tag 'upstream/0.99.6+dfsg'

Update to upstream version '0.99.6+dfsg'
with Debian dir ab8e2e26b3ee6a8405ff9a4246fb05b9d1e9be4d
- - - - -
5c389328 by Andreas Tille at 2020-12-18T16:56:01+01:00
routine-update: Standards-Version: 4.5.1

- - - - -
a8204b6f by Andreas Tille at 2020-12-18T16:56:01+01:00
routine-update: debhelper-compat 13

- - - - -
470f0d78 by Andreas Tille at 2020-12-18T16:56:05+01:00
routine-update: Add salsa-ci file

- - - - -
329041ed by Andreas Tille at 2020-12-18T16:56:05+01:00
routine-update: Rules-Requires-Root: no

- - - - -
c6101fd9 by Andreas Tille at 2020-12-18T16:56:11+01:00
Set upstream metadata fields: Bug-Database, Bug-Submit, Repository, Repository-Browse.

Changes-By: lintian-brush
Fixes: lintian: upstream-metadata-file-is-missing
See-also: https://lintian.debian.org/tags/upstream-metadata-file-is-missing.html
Fixes: lintian: upstream-metadata-missing-bug-tracking
See-also: https://lintian.debian.org/tags/upstream-metadata-missing-bug-tracking.html
Fixes: lintian: upstream-metadata-missing-repository
See-also: https://lintian.debian.org/tags/upstream-metadata-missing-repository.html

- - - - -
8e5a4cfe by Andreas Tille at 2020-12-18T18:06:51+01:00
Deactivate patches

- - - - -
7825557c by Andreas Tille at 2020-12-18T18:58:51+01:00
Create shared and static library

- - - - -


18 changed files:

- + .github/workflows/cppcmake.yml
- + CHANGELOG.txt
- CMakeLists.txt
- LICENSE.txt
- README.md
- debian/changelog
- debian/control
- debian/patches/series
- + debian/patches/shared_and_static.patch
- + debian/salsa-ci.yml
- + debian/upstream/metadata
- smarc/filtering.c
- smarc/filtering.h
- smarc/polyfilt.c
- smarc/polyfilt.h
- xdf.cpp
- xdf.h
- xdf.pro


Changes:

=====================================
.github/workflows/cppcmake.yml
=====================================
@@ -0,0 +1,76 @@
+name: C/C++ CI
+
+on:
+  push:
+    tags:
+    - v*.*
+  pull_request:
+    branches:
+    - master
+
+jobs:
+  build:
+    name: ${{ matrix.config.name }}
+    runs-on: ${{ matrix.config.os }}
+    strategy:
+      matrix:
+        config:
+          - {name: "ubuntu-latest", os: ubuntu-latest, cmake_extra: ""}
+          - {name: "windows-x64", os: windows-latest, cmake_extra: "-T v140"}
+          - {name: "windows-32", os: windows-latest, cmake_extra: "-T v140 -A Win32"}
+          - {name: "macOS-latest", os: macOS-latest, cmake_extra: ""}
+      fail-fast: false
+    
+    steps:
+    - uses: actions/checkout at v2
+    
+    - name: CMake version
+      run: cmake --version
+    
+    - name: Configure CMake
+      shell: bash
+      run: |
+           cmake -S . -B build ${{ matrix.config.cmake_extra }} -DCMAKE_INSTALL_PREFIX=${PWD}/build/install -DCPACK_PACKAGE_DIRECTORY=${PWD}/build/package -DCPACK_DEBIAN_PACKAGE_SHLIBDEPS=ON
+    
+    - name: Make
+      run: cmake --build build --config Release -j
+      
+    - name: Install
+      run: cmake --build build --config Release -j --target install
+      
+    - name: Package
+      run: cmake --build build --config Release -j --target package
+      
+    - name: Upload Artifact
+      uses: actions/upload-artifact at master
+      # if: "!startsWith(github.ref, 'refs/heads')"
+      with:
+        name: pkg-${{ matrix.config.name }}
+        path: |
+            build/package/*.deb
+            build/package/*.tar.bz2
+            build/package/*.zip
+
+
+  release:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+    
+    - name: Download Artifacts
+      if: startsWith(github.ref, 'refs/tags/')
+      uses: actions/download-artifact at v2
+      
+    - name: Create Release
+      if: startsWith(github.ref, 'refs/tags/')
+      id: create_release
+      uses: softprops/action-gh-release at v1
+      env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        # tag_name: ${{ github.ref }}  # ${{ github.ref }} is default
+        name: Release ${{ github.ref }}
+        draft: false
+        prerelease: false
+        # body_path: CHANGELOG.txt
+        files: 'pkg-*/*'


=====================================
CHANGELOG.txt
=====================================
@@ -0,0 +1,5 @@
+# Changelog
+
+## [0.992] - 2020-11-11
+### Added
+- GitHub Actions for automatic build on pull requests to master and automatic build and release on tags.


=====================================
CMakeLists.txt
=====================================
@@ -1,14 +1,16 @@
 cmake_minimum_required(VERSION 3.7)
 set(CMAKE_OSX_DEPLOYMENT_TARGET 10.9)
 
-project(libxdf)
+project(libxdf
+        VERSION 0.99.6
+        DESCRIPTION "C++ library for loading multimodal, multi-rate signals stored in XDF files."
+        HOMEPAGE_URL https://xdf-modules.github.io/libxdf/)
+
+option(XDF_NO_SYSTEM_PUGIXML "Force use of bundled pugixml" OFF)
 
 set(SOURCES
     xdf.h
     xdf.cpp
-    pugixml/pugiconfig.hpp
-    pugixml/pugixml.hpp
-    pugixml/pugixml.cpp
     smarc/filtering.h
     smarc/filtering.c
     smarc/multi_stage.h
@@ -23,10 +25,48 @@ set(SOURCES
     smarc/stage_impl.c
 )
 
-add_library(xdf-static STATIC ${SOURCES})
-add_library(xdf-shared SHARED ${SOURCES})
+add_library(xdf ${SOURCES})
+
+find_package(pugixml 1.9 QUIET)
+if(TARGET pugixml AND NOT XDF_NO_SYSTEM_PUGIXML)
+	message(STATUS "Using system pugixml")
+	target_link_libraries(xdf PRIVATE pugixml)
+else()
+	message(STATUS "Using bundled pugixml")
+	target_sources(xdf PRIVATE pugixml/pugixml.cpp)
+	target_include_directories(xdf PRIVATE pugixml)
+endif()
+
+target_compile_features(xdf PUBLIC cxx_std_11)
+set_target_properties(xdf PROPERTIES OUTPUT_NAME xdf PUBLIC_HEADER xdf.h)
+target_include_directories(xdf PUBLIC
+	$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>
+	$<INSTALL_INTERFACE:include>
+)
+include(GNUInstallDirs)
+install(TARGETS xdf
+	EXPORT "${PROJECT_NAME}Config"
+	ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
+	LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+	PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
+)
+install(EXPORT "${PROJECT_NAME}Config"
+	COMPONENT ${PROJECT_NAME}
+	NAMESPACE "XDF::"
+	DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}
+)
+
+# set(CPACK_STRIP_FILES ON)
+# set(CPACK_ARCHIVE_COMPONENT_INSTALL ON)
+set(CPACK_PACKAGE_CONTACT "yl3842 at columbia.edu")
+if(APPLE)
+    set(CPACK_GENERATOR TBZ2)
+elseif(WIN32)
+    set(CPACK_GENERATOR ZIP)
+elseif(UNIX)
+    set(CPACK_GENERATOR DEB)
+    set(CPACK_DEBIAN_LIBLSL_PACKAGE_SHLIBDEPS ON)
+    set(CPACK_DEBIAN_PACKAGE_GENERATE_SHLIBS ON)
+endif()
+include(CPack)
 
-set_property(TARGET xdf-static xdf-shared PROPERTY CXX_STANDARD 11)
-set_property(TARGET xdf-static xdf-shared PROPERTY C_STANDARD 99)
-set_target_properties(xdf-static PROPERTIES OUTPUT_NAME xdf)
-set_target_properties(xdf-shared PROPERTIES OUTPUT_NAME xdf)


=====================================
LICENSE.txt
=====================================
@@ -1,674 +1,27 @@
-                    GNU GENERAL PUBLIC LICENSE
-                       Version 3, 29 June 2007
-
- Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
- Everyone is permitted to copy and distribute verbatim copies
- of this license document, but changing it is not allowed.
-
-                            Preamble
-
-  The GNU General Public License is a free, copyleft license for
-software and other kinds of works.
-
-  The licenses for most software and other practical works are designed
-to take away your freedom to share and change the works.  By contrast,
-the GNU General Public License is intended to guarantee your freedom to
-share and change all versions of a program--to make sure it remains free
-software for all its users.  We, the Free Software Foundation, use the
-GNU General Public License for most of our software; it applies also to
-any other work released this way by its authors.  You can apply it to
-your programs, too.
-
-  When we speak of free software, we are referring to freedom, not
-price.  Our General Public Licenses are designed to make sure that you
-have the freedom to distribute copies of free software (and charge for
-them if you wish), that you receive source code or can get it if you
-want it, that you can change the software or use pieces of it in new
-free programs, and that you know you can do these things.
-
-  To protect your rights, we need to prevent others from denying you
-these rights or asking you to surrender the rights.  Therefore, you have
-certain responsibilities if you distribute copies of the software, or if
-you modify it: responsibilities to respect the freedom of others.
-
-  For example, if you distribute copies of such a program, whether
-gratis or for a fee, you must pass on to the recipients the same
-freedoms that you received.  You must make sure that they, too, receive
-or can get the source code.  And you must show them these terms so they
-know their rights.
-
-  Developers that use the GNU GPL protect your rights with two steps:
-(1) assert copyright on the software, and (2) offer you this License
-giving you legal permission to copy, distribute and/or modify it.
-
-  For the developers' and authors' protection, the GPL clearly explains
-that there is no warranty for this free software.  For both users' and
-authors' sake, the GPL requires that modified versions be marked as
-changed, so that their problems will not be attributed erroneously to
-authors of previous versions.
-
-  Some devices are designed to deny users access to install or run
-modified versions of the software inside them, although the manufacturer
-can do so.  This is fundamentally incompatible with the aim of
-protecting users' freedom to change the software.  The systematic
-pattern of such abuse occurs in the area of products for individuals to
-use, which is precisely where it is most unacceptable.  Therefore, we
-have designed this version of the GPL to prohibit the practice for those
-products.  If such problems arise substantially in other domains, we
-stand ready to extend this provision to those domains in future versions
-of the GPL, as needed to protect the freedom of users.
-
-  Finally, every program is threatened constantly by software patents.
-States should not allow patents to restrict development and use of
-software on general-purpose computers, but in those that do, we wish to
-avoid the special danger that patents applied to a free program could
-make it effectively proprietary.  To prevent this, the GPL assures that
-patents cannot be used to render the program non-free.
-
-  The precise terms and conditions for copying, distribution and
-modification follow.
-
-                       TERMS AND CONDITIONS
-
-  0. Definitions.
-
-  "This License" refers to version 3 of the GNU General Public License.
-
-  "Copyright" also means copyright-like laws that apply to other kinds of
-works, such as semiconductor masks.
-
-  "The Program" refers to any copyrightable work licensed under this
-License.  Each licensee is addressed as "you".  "Licensees" and
-"recipients" may be individuals or organizations.
-
-  To "modify" a work means to copy from or adapt all or part of the work
-in a fashion requiring copyright permission, other than the making of an
-exact copy.  The resulting work is called a "modified version" of the
-earlier work or a work "based on" the earlier work.
-
-  A "covered work" means either the unmodified Program or a work based
-on the Program.
-
-  To "propagate" a work means to do anything with it that, without
-permission, would make you directly or secondarily liable for
-infringement under applicable copyright law, except executing it on a
-computer or modifying a private copy.  Propagation includes copying,
-distribution (with or without modification), making available to the
-public, and in some countries other activities as well.
-
-  To "convey" a work means any kind of propagation that enables other
-parties to make or receive copies.  Mere interaction with a user through
-a computer network, with no transfer of a copy, is not conveying.
-
-  An interactive user interface displays "Appropriate Legal Notices"
-to the extent that it includes a convenient and prominently visible
-feature that (1) displays an appropriate copyright notice, and (2)
-tells the user that there is no warranty for the work (except to the
-extent that warranties are provided), that licensees may convey the
-work under this License, and how to view a copy of this License.  If
-the interface presents a list of user commands or options, such as a
-menu, a prominent item in the list meets this criterion.
-
-  1. Source Code.
-
-  The "source code" for a work means the preferred form of the work
-for making modifications to it.  "Object code" means any non-source
-form of a work.
-
-  A "Standard Interface" means an interface that either is an official
-standard defined by a recognized standards body, or, in the case of
-interfaces specified for a particular programming language, one that
-is widely used among developers working in that language.
-
-  The "System Libraries" of an executable work include anything, other
-than the work as a whole, that (a) is included in the normal form of
-packaging a Major Component, but which is not part of that Major
-Component, and (b) serves only to enable use of the work with that
-Major Component, or to implement a Standard Interface for which an
-implementation is available to the public in source code form.  A
-"Major Component", in this context, means a major essential component
-(kernel, window system, and so on) of the specific operating system
-(if any) on which the executable work runs, or a compiler used to
-produce the work, or an object code interpreter used to run it.
-
-  The "Corresponding Source" for a work in object code form means all
-the source code needed to generate, install, and (for an executable
-work) run the object code and to modify the work, including scripts to
-control those activities.  However, it does not include the work's
-System Libraries, or general-purpose tools or generally available free
-programs which are used unmodified in performing those activities but
-which are not part of the work.  For example, Corresponding Source
-includes interface definition files associated with source files for
-the work, and the source code for shared libraries and dynamically
-linked subprograms that the work is specifically designed to require,
-such as by intimate data communication or control flow between those
-subprograms and other parts of the work.
-
-  The Corresponding Source need not include anything that users
-can regenerate automatically from other parts of the Corresponding
-Source.
-
-  The Corresponding Source for a work in source code form is that
-same work.
-
-  2. Basic Permissions.
-
-  All rights granted under this License are granted for the term of
-copyright on the Program, and are irrevocable provided the stated
-conditions are met.  This License explicitly affirms your unlimited
-permission to run the unmodified Program.  The output from running a
-covered work is covered by this License only if the output, given its
-content, constitutes a covered work.  This License acknowledges your
-rights of fair use or other equivalent, as provided by copyright law.
-
-  You may make, run and propagate covered works that you do not
-convey, without conditions so long as your license otherwise remains
-in force.  You may convey covered works to others for the sole purpose
-of having them make modifications exclusively for you, or provide you
-with facilities for running those works, provided that you comply with
-the terms of this License in conveying all material for which you do
-not control copyright.  Those thus making or running the covered works
-for you must do so exclusively on your behalf, under your direction
-and control, on terms that prohibit them from making any copies of
-your copyrighted material outside their relationship with you.
-
-  Conveying under any other circumstances is permitted solely under
-the conditions stated below.  Sublicensing is not allowed; section 10
-makes it unnecessary.
-
-  3. Protecting Users' Legal Rights From Anti-Circumvention Law.
-
-  No covered work shall be deemed part of an effective technological
-measure under any applicable law fulfilling obligations under article
-11 of the WIPO copyright treaty adopted on 20 December 1996, or
-similar laws prohibiting or restricting circumvention of such
-measures.
-
-  When you convey a covered work, you waive any legal power to forbid
-circumvention of technological measures to the extent such circumvention
-is effected by exercising rights under this License with respect to
-the covered work, and you disclaim any intention to limit operation or
-modification of the work as a means of enforcing, against the work's
-users, your or third parties' legal rights to forbid circumvention of
-technological measures.
-
-  4. Conveying Verbatim Copies.
-
-  You may convey verbatim copies of the Program's source code as you
-receive it, in any medium, provided that you conspicuously and
-appropriately publish on each copy an appropriate copyright notice;
-keep intact all notices stating that this License and any
-non-permissive terms added in accord with section 7 apply to the code;
-keep intact all notices of the absence of any warranty; and give all
-recipients a copy of this License along with the Program.
-
-  You may charge any price or no price for each copy that you convey,
-and you may offer support or warranty protection for a fee.
-
-  5. Conveying Modified Source Versions.
-
-  You may convey a work based on the Program, or the modifications to
-produce it from the Program, in the form of source code under the
-terms of section 4, provided that you also meet all of these conditions:
-
-    a) The work must carry prominent notices stating that you modified
-    it, and giving a relevant date.
-
-    b) The work must carry prominent notices stating that it is
-    released under this License and any conditions added under section
-    7.  This requirement modifies the requirement in section 4 to
-    "keep intact all notices".
-
-    c) You must license the entire work, as a whole, under this
-    License to anyone who comes into possession of a copy.  This
-    License will therefore apply, along with any applicable section 7
-    additional terms, to the whole of the work, and all its parts,
-    regardless of how they are packaged.  This License gives no
-    permission to license the work in any other way, but it does not
-    invalidate such permission if you have separately received it.
-
-    d) If the work has interactive user interfaces, each must display
-    Appropriate Legal Notices; however, if the Program has interactive
-    interfaces that do not display Appropriate Legal Notices, your
-    work need not make them do so.
-
-  A compilation of a covered work with other separate and independent
-works, which are not by their nature extensions of the covered work,
-and which are not combined with it such as to form a larger program,
-in or on a volume of a storage or distribution medium, is called an
-"aggregate" if the compilation and its resulting copyright are not
-used to limit the access or legal rights of the compilation's users
-beyond what the individual works permit.  Inclusion of a covered work
-in an aggregate does not cause this License to apply to the other
-parts of the aggregate.
-
-  6. Conveying Non-Source Forms.
-
-  You may convey a covered work in object code form under the terms
-of sections 4 and 5, provided that you also convey the
-machine-readable Corresponding Source under the terms of this License,
-in one of these ways:
-
-    a) Convey the object code in, or embodied in, a physical product
-    (including a physical distribution medium), accompanied by the
-    Corresponding Source fixed on a durable physical medium
-    customarily used for software interchange.
-
-    b) Convey the object code in, or embodied in, a physical product
-    (including a physical distribution medium), accompanied by a
-    written offer, valid for at least three years and valid for as
-    long as you offer spare parts or customer support for that product
-    model, to give anyone who possesses the object code either (1) a
-    copy of the Corresponding Source for all the software in the
-    product that is covered by this License, on a durable physical
-    medium customarily used for software interchange, for a price no
-    more than your reasonable cost of physically performing this
-    conveying of source, or (2) access to copy the
-    Corresponding Source from a network server at no charge.
-
-    c) Convey individual copies of the object code with a copy of the
-    written offer to provide the Corresponding Source.  This
-    alternative is allowed only occasionally and noncommercially, and
-    only if you received the object code with such an offer, in accord
-    with subsection 6b.
-
-    d) Convey the object code by offering access from a designated
-    place (gratis or for a charge), and offer equivalent access to the
-    Corresponding Source in the same way through the same place at no
-    further charge.  You need not require recipients to copy the
-    Corresponding Source along with the object code.  If the place to
-    copy the object code is a network server, the Corresponding Source
-    may be on a different server (operated by you or a third party)
-    that supports equivalent copying facilities, provided you maintain
-    clear directions next to the object code saying where to find the
-    Corresponding Source.  Regardless of what server hosts the
-    Corresponding Source, you remain obligated to ensure that it is
-    available for as long as needed to satisfy these requirements.
-
-    e) Convey the object code using peer-to-peer transmission, provided
-    you inform other peers where the object code and Corresponding
-    Source of the work are being offered to the general public at no
-    charge under subsection 6d.
-
-  A separable portion of the object code, whose source code is excluded
-from the Corresponding Source as a System Library, need not be
-included in conveying the object code work.
-
-  A "User Product" is either (1) a "consumer product", which means any
-tangible personal property which is normally used for personal, family,
-or household purposes, or (2) anything designed or sold for incorporation
-into a dwelling.  In determining whether a product is a consumer product,
-doubtful cases shall be resolved in favor of coverage.  For a particular
-product received by a particular user, "normally used" refers to a
-typical or common use of that class of product, regardless of the status
-of the particular user or of the way in which the particular user
-actually uses, or expects or is expected to use, the product.  A product
-is a consumer product regardless of whether the product has substantial
-commercial, industrial or non-consumer uses, unless such uses represent
-the only significant mode of use of the product.
-
-  "Installation Information" for a User Product means any methods,
-procedures, authorization keys, or other information required to install
-and execute modified versions of a covered work in that User Product from
-a modified version of its Corresponding Source.  The information must
-suffice to ensure that the continued functioning of the modified object
-code is in no case prevented or interfered with solely because
-modification has been made.
-
-  If you convey an object code work under this section in, or with, or
-specifically for use in, a User Product, and the conveying occurs as
-part of a transaction in which the right of possession and use of the
-User Product is transferred to the recipient in perpetuity or for a
-fixed term (regardless of how the transaction is characterized), the
-Corresponding Source conveyed under this section must be accompanied
-by the Installation Information.  But this requirement does not apply
-if neither you nor any third party retains the ability to install
-modified object code on the User Product (for example, the work has
-been installed in ROM).
-
-  The requirement to provide Installation Information does not include a
-requirement to continue to provide support service, warranty, or updates
-for a work that has been modified or installed by the recipient, or for
-the User Product in which it has been modified or installed.  Access to a
-network may be denied when the modification itself materially and
-adversely affects the operation of the network or violates the rules and
-protocols for communication across the network.
-
-  Corresponding Source conveyed, and Installation Information provided,
-in accord with this section must be in a format that is publicly
-documented (and with an implementation available to the public in
-source code form), and must require no special password or key for
-unpacking, reading or copying.
-
-  7. Additional Terms.
-
-  "Additional permissions" are terms that supplement the terms of this
-License by making exceptions from one or more of its conditions.
-Additional permissions that are applicable to the entire Program shall
-be treated as though they were included in this License, to the extent
-that they are valid under applicable law.  If additional permissions
-apply only to part of the Program, that part may be used separately
-under those permissions, but the entire Program remains governed by
-this License without regard to the additional permissions.
-
-  When you convey a copy of a covered work, you may at your option
-remove any additional permissions from that copy, or from any part of
-it.  (Additional permissions may be written to require their own
-removal in certain cases when you modify the work.)  You may place
-additional permissions on material, added by you to a covered work,
-for which you have or can give appropriate copyright permission.
-
-  Notwithstanding any other provision of this License, for material you
-add to a covered work, you may (if authorized by the copyright holders of
-that material) supplement the terms of this License with terms:
-
-    a) Disclaiming warranty or limiting liability differently from the
-    terms of sections 15 and 16 of this License; or
-
-    b) Requiring preservation of specified reasonable legal notices or
-    author attributions in that material or in the Appropriate Legal
-    Notices displayed by works containing it; or
-
-    c) Prohibiting misrepresentation of the origin of that material, or
-    requiring that modified versions of such material be marked in
-    reasonable ways as different from the original version; or
-
-    d) Limiting the use for publicity purposes of names of licensors or
-    authors of the material; or
-
-    e) Declining to grant rights under trademark law for use of some
-    trade names, trademarks, or service marks; or
-
-    f) Requiring indemnification of licensors and authors of that
-    material by anyone who conveys the material (or modified versions of
-    it) with contractual assumptions of liability to the recipient, for
-    any liability that these contractual assumptions directly impose on
-    those licensors and authors.
-
-  All other non-permissive additional terms are considered "further
-restrictions" within the meaning of section 10.  If the Program as you
-received it, or any part of it, contains a notice stating that it is
-governed by this License along with a term that is a further
-restriction, you may remove that term.  If a license document contains
-a further restriction but permits relicensing or conveying under this
-License, you may add to a covered work material governed by the terms
-of that license document, provided that the further restriction does
-not survive such relicensing or conveying.
-
-  If you add terms to a covered work in accord with this section, you
-must place, in the relevant source files, a statement of the
-additional terms that apply to those files, or a notice indicating
-where to find the applicable terms.
-
-  Additional terms, permissive or non-permissive, may be stated in the
-form of a separately written license, or stated as exceptions;
-the above requirements apply either way.
-
-  8. Termination.
-
-  You may not propagate or modify a covered work except as expressly
-provided under this License.  Any attempt otherwise to propagate or
-modify it is void, and will automatically terminate your rights under
-this License (including any patent licenses granted under the third
-paragraph of section 11).
-
-  However, if you cease all violation of this License, then your
-license from a particular copyright holder is reinstated (a)
-provisionally, unless and until the copyright holder explicitly and
-finally terminates your license, and (b) permanently, if the copyright
-holder fails to notify you of the violation by some reasonable means
-prior to 60 days after the cessation.
-
-  Moreover, your license from a particular copyright holder is
-reinstated permanently if the copyright holder notifies you of the
-violation by some reasonable means, this is the first time you have
-received notice of violation of this License (for any work) from that
-copyright holder, and you cure the violation prior to 30 days after
-your receipt of the notice.
-
-  Termination of your rights under this section does not terminate the
-licenses of parties who have received copies or rights from you under
-this License.  If your rights have been terminated and not permanently
-reinstated, you do not qualify to receive new licenses for the same
-material under section 10.
-
-  9. Acceptance Not Required for Having Copies.
-
-  You are not required to accept this License in order to receive or
-run a copy of the Program.  Ancillary propagation of a covered work
-occurring solely as a consequence of using peer-to-peer transmission
-to receive a copy likewise does not require acceptance.  However,
-nothing other than this License grants you permission to propagate or
-modify any covered work.  These actions infringe copyright if you do
-not accept this License.  Therefore, by modifying or propagating a
-covered work, you indicate your acceptance of this License to do so.
-
-  10. Automatic Licensing of Downstream Recipients.
-
-  Each time you convey a covered work, the recipient automatically
-receives a license from the original licensors, to run, modify and
-propagate that work, subject to this License.  You are not responsible
-for enforcing compliance by third parties with this License.
-
-  An "entity transaction" is a transaction transferring control of an
-organization, or substantially all assets of one, or subdividing an
-organization, or merging organizations.  If propagation of a covered
-work results from an entity transaction, each party to that
-transaction who receives a copy of the work also receives whatever
-licenses to the work the party's predecessor in interest had or could
-give under the previous paragraph, plus a right to possession of the
-Corresponding Source of the work from the predecessor in interest, if
-the predecessor has it or can get it with reasonable efforts.
-
-  You may not impose any further restrictions on the exercise of the
-rights granted or affirmed under this License.  For example, you may
-not impose a license fee, royalty, or other charge for exercise of
-rights granted under this License, and you may not initiate litigation
-(including a cross-claim or counterclaim in a lawsuit) alleging that
-any patent claim is infringed by making, using, selling, offering for
-sale, or importing the Program or any portion of it.
-
-  11. Patents.
-
-  A "contributor" is a copyright holder who authorizes use under this
-License of the Program or a work on which the Program is based.  The
-work thus licensed is called the contributor's "contributor version".
-
-  A contributor's "essential patent claims" are all patent claims
-owned or controlled by the contributor, whether already acquired or
-hereafter acquired, that would be infringed by some manner, permitted
-by this License, of making, using, or selling its contributor version,
-but do not include claims that would be infringed only as a
-consequence of further modification of the contributor version.  For
-purposes of this definition, "control" includes the right to grant
-patent sublicenses in a manner consistent with the requirements of
-this License.
-
-  Each contributor grants you a non-exclusive, worldwide, royalty-free
-patent license under the contributor's essential patent claims, to
-make, use, sell, offer for sale, import and otherwise run, modify and
-propagate the contents of its contributor version.
-
-  In the following three paragraphs, a "patent license" is any express
-agreement or commitment, however denominated, not to enforce a patent
-(such as an express permission to practice a patent or covenant not to
-sue for patent infringement).  To "grant" such a patent license to a
-party means to make such an agreement or commitment not to enforce a
-patent against the party.
-
-  If you convey a covered work, knowingly relying on a patent license,
-and the Corresponding Source of the work is not available for anyone
-to copy, free of charge and under the terms of this License, through a
-publicly available network server or other readily accessible means,
-then you must either (1) cause the Corresponding Source to be so
-available, or (2) arrange to deprive yourself of the benefit of the
-patent license for this particular work, or (3) arrange, in a manner
-consistent with the requirements of this License, to extend the patent
-license to downstream recipients.  "Knowingly relying" means you have
-actual knowledge that, but for the patent license, your conveying the
-covered work in a country, or your recipient's use of the covered work
-in a country, would infringe one or more identifiable patents in that
-country that you have reason to believe are valid.
-
-  If, pursuant to or in connection with a single transaction or
-arrangement, you convey, or propagate by procuring conveyance of, a
-covered work, and grant a patent license to some of the parties
-receiving the covered work authorizing them to use, propagate, modify
-or convey a specific copy of the covered work, then the patent license
-you grant is automatically extended to all recipients of the covered
-work and works based on it.
-
-  A patent license is "discriminatory" if it does not include within
-the scope of its coverage, prohibits the exercise of, or is
-conditioned on the non-exercise of one or more of the rights that are
-specifically granted under this License.  You may not convey a covered
-work if you are a party to an arrangement with a third party that is
-in the business of distributing software, under which you make payment
-to the third party based on the extent of your activity of conveying
-the work, and under which the third party grants, to any of the
-parties who would receive the covered work from you, a discriminatory
-patent license (a) in connection with copies of the covered work
-conveyed by you (or copies made from those copies), or (b) primarily
-for and in connection with specific products or compilations that
-contain the covered work, unless you entered into that arrangement,
-or that patent license was granted, prior to 28 March 2007.
-
-  Nothing in this License shall be construed as excluding or limiting
-any implied license or other defenses to infringement that may
-otherwise be available to you under applicable patent law.
-
-  12. No Surrender of Others' Freedom.
-
-  If conditions are imposed on you (whether by court order, agreement or
-otherwise) that contradict the conditions of this License, they do not
-excuse you from the conditions of this License.  If you cannot convey a
-covered work so as to satisfy simultaneously your obligations under this
-License and any other pertinent obligations, then as a consequence you may
-not convey it at all.  For example, if you agree to terms that obligate you
-to collect a royalty for further conveying from those to whom you convey
-the Program, the only way you could satisfy both those terms and this
-License would be to refrain entirely from conveying the Program.
-
-  13. Use with the GNU Affero General Public License.
-
-  Notwithstanding any other provision of this License, you have
-permission to link or combine any covered work with a work licensed
-under version 3 of the GNU Affero General Public License into a single
-combined work, and to convey the resulting work.  The terms of this
-License will continue to apply to the part which is the covered work,
-but the special requirements of the GNU Affero General Public License,
-section 13, concerning interaction through a network will apply to the
-combination as such.
-
-  14. Revised Versions of this License.
-
-  The Free Software Foundation may publish revised and/or new versions of
-the GNU General Public License from time to time.  Such new versions will
-be similar in spirit to the present version, but may differ in detail to
-address new problems or concerns.
-
-  Each version is given a distinguishing version number.  If the
-Program specifies that a certain numbered version of the GNU General
-Public License "or any later version" applies to it, you have the
-option of following the terms and conditions either of that numbered
-version or of any later version published by the Free Software
-Foundation.  If the Program does not specify a version number of the
-GNU General Public License, you may choose any version ever published
-by the Free Software Foundation.
-
-  If the Program specifies that a proxy can decide which future
-versions of the GNU General Public License can be used, that proxy's
-public statement of acceptance of a version permanently authorizes you
-to choose that version for the Program.
-
-  Later license versions may give you additional or different
-permissions.  However, no additional obligations are imposed on any
-author or copyright holder as a result of your choosing to follow a
-later version.
-
-  15. Disclaimer of Warranty.
-
-  THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY
-APPLICABLE LAW.  EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT
-HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY
-OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO,
-THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM
-IS WITH YOU.  SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF
-ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
-
-  16. Limitation of Liability.
-
-  IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
-WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS
-THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY
-GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE
-USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF
-DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD
-PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS),
-EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGES.
-
-  17. Interpretation of Sections 15 and 16.
-
-  If the disclaimer of warranty and limitation of liability provided
-above cannot be given local legal effect according to their terms,
-reviewing courts shall apply local law that most closely approximates
-an absolute waiver of all civil liability in connection with the
-Program, unless a warranty or assumption of liability accompanies a
-copy of the Program in return for a fee.
-
-                     END OF TERMS AND CONDITIONS
-
-            How to Apply These Terms to Your New Programs
-
-  If you develop a new program, and you want it to be of the greatest
-possible use to the public, the best way to achieve this is to make it
-free software which everyone can redistribute and change under these terms.
-
-  To do so, attach the following notices to the program.  It is safest
-to attach them to the start of each source file to most effectively
-state the exclusion of warranty; and each file should have at least
-the "copyright" line and a pointer to where the full notice is found.
-
-    {one line to give the program's name and a brief idea of what it does.}
-    Copyright (C) {year}  {name of author}
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>..
-
-Also add information on how to contact you by electronic and paper mail.
-
-  If the program does terminal interaction, make it output a short
-notice like this when it starts in an interactive mode:
-
-    {project}  Copyright (C) {year}  {fullname}
-    This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-    This is free software, and you are welcome to redistribute it
-    under certain conditions; type `show c' for details.
-
-The hypothetical commands `show w' and `show c' should show the appropriate
-parts of the General Public License.  Of course, your program's commands
-might be different; for a GUI interface, you would use an "about box".
-
-  You should also get your employer (if you work as a programmer) or school,
-if any, to sign a "copyright disclaimer" for the program, if necessary.
-For more information on this, and how to apply and follow the GNU GPL, see
-<http://www.gnu.org/licenses/>.
-
-  The GNU General Public License does not permit incorporating your program
-into proprietary programs.  If your program is a subroutine library, you
-may consider it more useful to permit linking proprietary applications with
-the library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.  But first, please read
-<http://www.gnu.org/philosophy/why-not-lgpl.html>.
\ No newline at end of file
+BSD 2-Clause License
+
+Copyright (c) 2017-2020, Yida Lin
+Copyright (c) 2017-2020, Clemens Brunner
+Copyright (c) 2017-2020, Paul Sajda
+Copyright (c) 2017-2020, Josef Faller
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+* Redistributions of source code must retain the above copyright notice, this
+  list of conditions and the following disclaimer.
+
+* Redistributions in binary form must reproduce the above copyright notice,
+  this list of conditions and the following disclaimer in the documentation
+  and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


=====================================
README.md
=====================================
@@ -1,33 +1,49 @@
 # Libxdf - a C++ library for loading [XDF](https://github.com/sccn/xdf/wiki/Specifications "Extensible Data Format") files
 
+[![Project Status: Active – The project has reached a stable, usable state and is being actively developed.](http://www.repostatus.org/badges/latest/active.svg)](http://www.repostatus.org/#active)
+[![License](https://img.shields.io/github/license/xdf-modules/libxdf)](https://opensource.org/licenses/BSD-2-Clause)
 
 * [Introduction](#intro)
-* [Download](#download)
 * [Quick-Start Guide](#quick)
+    * [Download](#download)
 * [Documentation](#doc)
+* [Reference](#reference)
 * [Support](#support)
 
 
 ## <a name="intro"></a>Introduction
 
 Libxdf is a cross-platform C++ library for loading multimodal, multi-rate signals stored in [XDF](https://github.com/sccn/xdf/wiki/Specifications  "Extensible Data Format") files.
-Libxdf is used in the  biosignal viewing application [SigViewer](https://github.com/cbrnr/sigviewer). It can also be integrated into other
-C++ applications.
+Libxdf is used in the biosignal viewing application [SigViewer](https://github.com/cbrnr/sigviewer) and the LSL application [XDFStreamer](https://github.com/labstreaminglayer/App-XDFStreamer/). It can also be integrated into other C++ applications.
 
 Libxdf is open-source, free, and actively maintained.
 
+## <a name="quick"></a>Quick-Start Guide
 
-## <a name="download"></a>Download
-
-* [Source code (zip)](https://github.com/Yida-Lin/libxdf/archive/0.94.zip)
-* [Source code (tar.gz)](https://github.com/Yida-Lin/libxdf/archive/0.94.tar.gz)
-* [Pre-built binaries](https://github.com/Yida-Lin/libxdf/releases)
+### <a name="download"></a>Download
 
-## <a name="quick"></a>Quick-Start Guide
+* Find Source and Prebuilt Binaries on the [releases page](https://github.com/Yida-Lin/libxdf/releases).
+    * You may need to expand the list of Assets to find the downloads.
+* For Linux Debian (Ubuntu) users: `sudo dpkg -i libxdf-{version}-Linux.deb`
+* For Windows and Mac users: simply extract the archive somewhere convenient.
 
 ### Building libxdf
+
+If the release does not have assets for your platform or they do not work for you for some other reason, then
 Libxdf can be conveniently built either using `qmake` or `cmake`. Configuration files for both build tools are included with the source.
 
+To build with cmake from command prompt / terminal:
+
+```sh
+cmake -S . -B build -DCMAKE_INSTALL_PREFIX=${PWD}/build/install
+cmake --build build --config Release -j --target install
+```
+
+`cmake` builds a static library by default, but you can build a shared library
+by setting the
+[`BUILD_SHARED_LIBS`](https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html)
+variable (e.g. add `-DBUILD_SHARED_LIBS=ON` to the first cmake command above).
+
 ### Use in conjunction with [SigViewer](https://github.com/cbrnr/sigviewer)
 
 Libxdf is a built-in component of [SigViewer](https://github.com/cbrnr/sigviewer). If you wish to build SigViewer from source, follow these steps:
@@ -44,8 +60,22 @@ Example: SigViewer using _libxdf_ to display signals in an XDF file.
 
 ### Use in other C++ applications
 
-1. Build libxdf from source or use a pre-built binary release
-2. Instantiate an object of the `Xdf` class and call the `load_xdf` method.
+1. Install a prebuilt binary release or build from source as above.
+2. For CMake users:
+    * In your project's CMakeLists.txt, use the following snippet:
+       ```CMake
+        find_package(libxdf REQUIRED
+            HINTS ${XDF_INSTALL_ROOT}
+            PATH_SUFFIXES share
+        )
+        target_link_libraries(${PROJECT_NAME}
+            PRIVATE
+            # ... other dependencies
+            XDF::xdf
+        )
+        ```
+    * If the libxdf package was installed or extracted into a folder other than a standard system library folder, you will have to pass a cmake command line argument to indicate where to find it: `-DXDF_INSTALL_ROOT=path/to/libxdf`
+3. In your source code, `#include "xdf.h"`, instantiate an object of the `Xdf` class and call the `load_xdf` method.
 
 Example:
 
@@ -82,6 +112,23 @@ Detailed documentation was generated via [Doxygen](http://www.stack.nl/~dimitri/
 ## <a name="SigViewer"></a> SigViewer Online Repo
 SigViewer Online Repository is [here](repository/Updates.xml).
 
-## <a name="support"></a>Support
+## <a name="reference"></a> Reference
+If you use this code in your project, please cite:
+```
+Yida Lin, Clemens Brunner, Paul Sajda and Josef Faller. SigViewer: Visualizing Multimodal Signals Stored in XDF (Extensible Data Format) Files. The 39th Annual International Conference of the IEEE Engineering in Medicine and Biology Society.
+```
+Direct link: https://arxiv.org/abs/1708.06333
 
+Bibtex format:
+```
+ at article{lin2017sigviewer,
+  title={SigViewer: visualizing multimodal signals stored in XDF (Extensible Data Format) files},
+  author={Lin, Yida and Brunner, Clemens and Sajda, Paul and Faller, Josef},
+  journal={arXiv},
+  pages={arXiv--1708},
+  year={2017}
+}
+```
+
+## <a name="support"></a>Support
 [Email author](mailto:yl3842 at columbia.edu) or report a new [issue](https://github.com/Yida-Lin/libxdf/issues).


=====================================
debian/changelog
=====================================
@@ -1,3 +1,15 @@
+libxdf (0.99.6+dfsg-1) UNRELEASED; urgency=medium
+
+  * New upstream version
+  * Standards-Version: 4.5.1 (routine-update)
+  * debhelper-compat 13 (routine-update)
+  * Add salsa-ci file (routine-update)
+  * Rules-Requires-Root: no (routine-update)
+  * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository,
+    Repository-Browse.
+
+ -- Andreas Tille <tille at debian.org>  Fri, 18 Dec 2020 16:56:00 +0100
+
 libxdf (0.99+dfsg-1) unstable; urgency=medium
 
   * New upstream version


=====================================
debian/control
=====================================
@@ -3,14 +3,15 @@ Maintainer: Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.
 Uploaders: Andreas Tille <tille at debian.org>
 Section: science
 Priority: optional
-Build-Depends: debhelper-compat (= 12),
+Build-Depends: debhelper-compat (= 13),
                cmake,
                d-shlibs,
                libpugixml-dev
-Standards-Version: 4.4.0
+Standards-Version: 4.5.1
 Vcs-Browser: https://salsa.debian.org/med-team/libxdf
 Vcs-Git: https://salsa.debian.org/med-team/libxdf.git
 Homepage: https://github.com/Yida-Lin/libxdf
+Rules-Requires-Root: no
 
 Package: libxdf0
 Architecture: any


=====================================
debian/patches/series
=====================================
@@ -1,2 +1,3 @@
-soversion.patch
-use_debian_packaged_pugixml.patch
+#soversion.patch
+#use_debian_packaged_pugixml.patch
+shared_and_static.patch


=====================================
debian/patches/shared_and_static.patch
=====================================
@@ -0,0 +1,35 @@
+Author: Andreas Tille <tille at debian.org>
+Last-Update: Fri, 18 Dec 2020 16:56:00 +0100
+Description: Create shared and static library
+
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -26,6 +26,7 @@ set(SOURCES
+ )
+ 
+ add_library(xdf ${SOURCES})
++add_library(xdf_shared SHARED ${SOURCES})
+ 
+ find_package(pugixml 1.9 QUIET)
+ if(TARGET pugixml AND NOT XDF_NO_SYSTEM_PUGIXML)
+@@ -39,6 +40,7 @@ endif()
+ 
+ target_compile_features(xdf PUBLIC cxx_std_11)
+ set_target_properties(xdf PROPERTIES OUTPUT_NAME xdf PUBLIC_HEADER xdf.h)
++set_target_properties(xdf_shared PROPERTIES OUTPUT_NAME xdf PUBLIC_HEADER xdf.h)
+ target_include_directories(xdf PUBLIC
+ 	$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>
+ 	$<INSTALL_INTERFACE:include>
+@@ -50,6 +52,12 @@ install(TARGETS xdf
+ 	LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+ 	PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
+ )
++install(TARGETS xdf_shared
++        EXPORT "${PROJECT_NAME}Config"
++        ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
++        LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
++        PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
++)
+ install(EXPORT "${PROJECT_NAME}Config"
+ 	COMPONENT ${PROJECT_NAME}
+ 	NAMESPACE "XDF::"


=====================================
debian/salsa-ci.yml
=====================================
@@ -0,0 +1,4 @@
+---
+include:
+  - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+  - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml


=====================================
debian/upstream/metadata
=====================================
@@ -0,0 +1,5 @@
+---
+Bug-Database: https://github.com/Yida-Lin/libxdf/issues
+Bug-Submit: https://github.com/Yida-Lin/libxdf/issues/new
+Repository: https://github.com/Yida-Lin/libxdf.git
+Repository-Browse: https://github.com/Yida-Lin/libxdf


=====================================
smarc/filtering.c
=====================================
@@ -26,7 +26,7 @@
 
 #ifndef __SSE2__
 
-double filter(const double* restrict filt, const double* restrict signal, const int K)
+double filter(const double* SMARC_RESTRICT filt, const double* SMARC_RESTRICT signal, const int K)
 {
 	register double v = 0.0;
 	for (int k=0;k<K;++k)
@@ -38,7 +38,7 @@ double filter(const double* restrict filt, const double* restrict signal, const
 
 #include <emmintrin.h>
 
-double basic_filter(const double* restrict filt, const double* restrict signal, const int K)
+double basic_filter(const double* SMARC_RESTRICT filt, const double* SMARC_RESTRICT signal, const int K)
 {
 //	printf("basic filter for K=%i\n",K);
 	register double v = 0.0;
@@ -47,7 +47,7 @@ double basic_filter(const double* restrict filt, const double* restrict signal,
 	return v;
 }
 
-double sse_filtering_aligned(const double* restrict filt, const double* restrict signal, const int K) {
+double sse_filtering_aligned(const double* SMARC_RESTRICT filt, const double* SMARC_RESTRICT signal, const int K) {
 //	printf("sse_filtering filt=%p signal=%p K=%i\n",filt,signal,K);
 	// filt and signal are 16 byte aligned, K % 2 = 0
 	__m128d v = _mm_setzero_pd();
@@ -65,7 +65,7 @@ double sse_filtering_aligned(const double* restrict filt, const double* restrict
 	return tmp[0] + tmp[1] + filt[k]*signal[k];
 }
 
-double sse_filtering_misaligned(const double* restrict filt, const double* restrict signal, const int K) {
+double sse_filtering_misaligned(const double* SMARC_RESTRICT filt, const double* SMARC_RESTRICT signal, const int K) {
 //	printf("sse_filtering_misaligned filt=%p signal=%p K=%i\n",filt,signal,K);
 	__m128d v = _mm_setzero_pd();
 	__m128d s = _mm_load1_pd(signal);
@@ -87,7 +87,7 @@ double sse_filtering_misaligned(const double* restrict filt, const double* restr
 	return tmp[0] + tmp[1];
 }
 
-double filter(const double* restrict filt, const double* restrict signal, int K)
+double filter(const double* SMARC_RESTRICT filt, const double* SMARC_RESTRICT signal, int K)
 {
 	if (K<8)
 		return basic_filter(filt,signal,K);


=====================================
smarc/filtering.h
=====================================
@@ -25,6 +25,12 @@
 #ifndef FILTER_H_
 #define FILTER_H_
 
-double filter(const double* restrict filt, const double* restrict signal, const int K);
+#ifdef _MSC_VER
+#define SMARC_RESTRICT __restrict
+#else
+#define SMARC_RESTRICT restrict
+#endif
+
+double filter(const double* SMARC_RESTRICT filt, const double* SMARC_RESTRICT signal, const int K);
 
 #endif /* FILTER_H_ */


=====================================
smarc/polyfilt.c
=====================================
@@ -71,8 +71,8 @@ void polyfiltLM(struct PSFilter* pfilt, struct PSState* pstate,
 
 
 void polyfiltM(struct PSFilter* pfilt, struct PSState* pstate,
-		const double* restrict signal, const int signalLen, int* restrict nbConsume,
-		double* restrict output, const int outputLen, int* restrict nbWritten) {
+		const double* SMARC_RESTRICT signal, const int signalLen, int* SMARC_RESTRICT nbConsume,
+		double* SMARC_RESTRICT output, const int outputLen, int* SMARC_RESTRICT nbWritten) {
 	const int M = pfilt->M;
 	const int K = pfilt->K;
 	const double* filt = pfilt->filters;


=====================================
smarc/polyfilt.h
=====================================
@@ -41,8 +41,8 @@
  * - w [IN]: workspace to use for temporary results.
  */
 void polyfiltLM(struct PSFilter* pfilt, struct PSState* pstate,
-		const double* restrict signal, const int signalLen, int* nbConsume,
-		double* restrict output, const int outputLen, int* nbWritten);
+		const double* SMARC_RESTRICT signal, const int signalLen, int* nbConsume,
+		double* SMARC_RESTRICT output, const int outputLen, int* nbWritten);
 
 /**
  * Filter signal with a decimation filter (interpolation factor L is 1)
@@ -57,8 +57,8 @@ void polyfiltLM(struct PSFilter* pfilt, struct PSState* pstate,
  * - w [IN]: workspace to use for temporary results.
  */
 void polyfiltM(struct PSFilter* pfilt, struct PSState* pstate,
-		const double* restrict signal, const int signalLen, int* restrict nbConsume,
-		double* restrict output, const int outputLen, int* restrict nbWritten);
+		const double* SMARC_RESTRICT signal, const int signalLen, int* SMARC_RESTRICT nbConsume,
+		double* SMARC_RESTRICT output, const int outputLen, int* SMARC_RESTRICT nbWritten);
 
 /**
  * Filter signal with a interpolation filter (decimation factor M is 1)
@@ -73,7 +73,7 @@ void polyfiltM(struct PSFilter* pfilt, struct PSState* pstate,
  * - w [IN]: workspace to use for temporary results.
  */
 void polyfiltL(struct PSFilter* pfilt, struct PSState* pstate,
-		const double* restrict signal, const int signalLen, int* restrict nbConsume,
-		double* restrict output, const int outputLen, int* restrict nbWritten);
+		const double* SMARC_RESTRICT signal, const int signalLen, int* SMARC_RESTRICT nbConsume,
+		double* SMARC_RESTRICT output, const int outputLen, int* SMARC_RESTRICT nbWritten);
 
 #endif /* POLYFILTLM_H_ */


=====================================
xdf.cpp
=====================================
@@ -20,7 +20,7 @@
 
 #include <iostream>
 #include <fstream>
-#include "pugixml/pugixml.hpp"  //pugi XML parser
+#include <pugixml.hpp>  //pugi XML parser
 #include <sstream>
 #include <algorithm>
 #include "smarc/smarc.h"      //resampling library
@@ -85,7 +85,7 @@ int Xdf::load_xdf(std::string filename)
                 break;
 
             uint16_t tag;   //read tag of the chunk, 6 possibilities
-            file.read(reinterpret_cast<char *>(&tag), 2);
+            readBin(file, &tag);
 
             switch (tag)
             {
@@ -109,9 +109,9 @@ int Xdf::load_xdf(std::string filename)
             case 2: //read [StreamHeader] chunk
             {
                 //read [StreamID]
-                int streamID;
+                uint32_t streamID;
                 int index;
-                file.read((char*)&streamID, 4);
+                Xdf::readBin(file, &streamID);
                 std::vector<int>::iterator it {std::find(idmap.begin(),idmap.end(),streamID)};
                 if (it == idmap.end())
                 {
@@ -160,9 +160,9 @@ int Xdf::load_xdf(std::string filename)
             case 3: //read [Samples] chunk
             {
                 //read [StreamID]
-                int streamID;
+                uint32_t streamID;
                 int index;
-                file.read((char*)&streamID, 4);
+                Xdf::readBin(file, &streamID);
                 std::vector<int>::iterator it {std::find(idmap.begin(),idmap.end(),streamID)};
                 if (it == idmap.end())
                 {
@@ -188,14 +188,13 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
                         {
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                             streams[index].time_stamps.emplace_back(ts);
                         }
                         else
@@ -210,7 +209,7 @@ int Xdf::load_xdf(std::string filename)
                         for (int v = 0; v < streams[index].info.channel_count; ++v)
                         {
                             float data;
-                            file.read((char*)&data, 4);
+                            Xdf::readBin(file, &data);
                             streams[index].time_series[v].emplace_back(data);
                         }
                     }
@@ -225,14 +224,13 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
                         {
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                             streams[index].time_stamps.emplace_back(ts);
                         }
                         else
@@ -247,7 +245,7 @@ int Xdf::load_xdf(std::string filename)
                         for (int v = 0; v < streams[index].info.channel_count; ++v)
                         {
                             double data;
-                            file.read((char*)&data, 8);
+                            Xdf::readBin(file, &data);
                             streams[index].time_series[v].emplace_back(data);
                         }
                     }
@@ -262,14 +260,13 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
                         {
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                             streams[index].time_stamps.emplace_back(ts);
                         }
                         else
@@ -284,7 +281,7 @@ int Xdf::load_xdf(std::string filename)
                         for (int v = 0; v < streams[index].info.channel_count; ++v)
                         {
                             int8_t data;
-                            file.read((char*)&data, 1);
+                            Xdf::readBin(file, &data);
                             streams[index].time_series[v].emplace_back(data);
                         }
                     }
@@ -299,14 +296,13 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
                         {
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                             streams[index].time_stamps.emplace_back(ts);
                         }
                         else
@@ -321,7 +317,7 @@ int Xdf::load_xdf(std::string filename)
                         for (int v = 0; v < streams[index].info.channel_count; ++v)
                         {
                             int16_t data;
-                            file.read((char*)&data, 2);
+                            Xdf::readBin(file, &data);
                             streams[index].time_series[v].emplace_back(data);
                         }
                     }
@@ -336,14 +332,13 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
                         {
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                             streams[index].time_stamps.emplace_back(ts);
                         }
                         else
@@ -358,7 +353,7 @@ int Xdf::load_xdf(std::string filename)
                         for (int v = 0; v < streams[index].info.channel_count; ++v)
                         {
                             int32_t data;
-                            file.read((char*)&data, 4);
+                            Xdf::readBin(file, &data);
                             streams[index].time_series[v].emplace_back(data);
                         }
                     }
@@ -373,14 +368,13 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
                         {
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                             streams[index].time_stamps.emplace_back(ts);
                         }
                         else
@@ -395,7 +389,7 @@ int Xdf::load_xdf(std::string filename)
                         for (int v = 0; v < streams[index].info.channel_count; ++v)
                         {
                             int64_t data;
-                            file.read((char*)&data, 8);
+                            Xdf::readBin(file, &data);
                             streams[index].time_series[v].emplace_back(data);
                         }
                     }
@@ -406,50 +400,23 @@ int Xdf::load_xdf(std::string filename)
                     for (size_t i = 0; i < numSamp; i++)
                     {
                         //read or deduce time stamp
-                        uint8_t tsBytes;
-                        file.read(reinterpret_cast<char *>(&tsBytes), 1);
+                        auto tsBytes = readBin<uint8_t>(file);
 
                         double ts;  //temporary time stamp
 
                         if (tsBytes == 8)
-                            file.read((char*)&ts, 8);
+                            Xdf::readBin(file, &ts);
                         else
                             ts = streams[index].last_timestamp + streams[index].sampling_interval;
 
                         //read the event
-                        int8_t bytes;
-                        file.read((char*)&bytes, 1);
-                        if (bytes == 1)
-                        {
-                            uint8_t length;
-                            file.read((char*)&length, 1);
-                            char* buffer = new char[length + 1];
-                            file.read(buffer, length);
-                            buffer[length] = '\0';
-                            eventMap.emplace_back(std::make_pair(buffer, ts), index);
-                            delete[] buffer;
-                        }
-                        else if (bytes == 4)
-                        {
-                            uint32_t length;
-                            file.read((char*)&length, 4);
-                            char* buffer = new char[length + 1];
-                            file.read(buffer, length);
-                            buffer[length] = '\0';
-                            eventMap.emplace_back(std::make_pair(buffer, ts), index);
-                            delete[] buffer;
-                        }
-                        else if (bytes == 8)
-                        {
-                            uint64_t length;
-                            file.read((char*)&length, 8);
-                            char* buffer = new char[length + 1];
-                            file.read(buffer, length);
-                            buffer[length] = '\0';
-                            eventMap.emplace_back(std::make_pair(buffer, ts), index);
-                            delete[] buffer;
-                        }
+                        auto length = Xdf::readLength(file);
 
+                        char* buffer = new char[length + 1];
+                        file.read(buffer, length);
+                        buffer[length] = '\0';
+                        eventMap.emplace_back(std::make_pair(buffer, ts), index);
+                        delete[] buffer;
                         streams[index].last_timestamp = ts;
                     }
                 }
@@ -457,9 +424,9 @@ int Xdf::load_xdf(std::string filename)
                 break;
             case 4: //read [ClockOffset] chunk
             {
-                int streamID;
+                uint32_t streamID;
                 int index;
-                file.read((char*)&streamID, 4);
+                Xdf::readBin(file, &streamID);
                 std::vector<int>::iterator it {std::find(idmap.begin(),idmap.end(),streamID)};
                 if (it == idmap.end())
                 {
@@ -474,8 +441,8 @@ int Xdf::load_xdf(std::string filename)
                 double collectionTime;
                 double offsetValue;
 
-                file.read((char*)&collectionTime, 8);
-                file.read((char*)&offsetValue, 8);
+                Xdf::readBin(file, &collectionTime);
+                Xdf::readBin(file, &offsetValue);
 
                 streams[index].clock_times.emplace_back(collectionTime);
                 streams[index].clock_values.emplace_back(offsetValue);
@@ -486,9 +453,9 @@ int Xdf::load_xdf(std::string filename)
                 pugi::xml_document doc;
 
                 //read [StreamID]
-                int streamID;
+                uint32_t streamID;
                 int index;
-                file.read((char*)&streamID, 4);
+                Xdf::readBin(file, &streamID);
                 std::vector<int>::iterator it {std::find(idmap.begin(),idmap.end(),streamID)};
                 if (it == idmap.end())
                 {
@@ -746,34 +713,27 @@ void Xdf::resample(int userSrate)
 uint64_t Xdf::readLength(std::ifstream &file)
 {
     uint8_t bytes;
-    file.read((char*)&bytes, 1);
+    Xdf::readBin(file, &bytes);
     uint64_t length = 0;
 
     switch (bytes)
     {
     case 1:
-    {
-        uint8_t buffer = 0;
-        file.read(reinterpret_cast<char *>(&buffer), 1);
-        length = buffer;
-        return length;
-    }
+        length = readBin<uint8_t>(file);
+        break;
     case 4:
-    {
-        uint32_t buffer = 0;
-        file.read(reinterpret_cast<char *>(&buffer), 4);
-        length = buffer;
-        return length;
-    }
+        length = readBin<uint32_t>(file);
+        break;
     case 8:
-    {
-        file.read(reinterpret_cast<char *>(&length), 8);
-        return length;
-    }
+        length = readBin<uint64_t>(file);
+        break;
     default:
-        std::cout << "Invalid variable-length integer encountered.\n";
+        std::cout << "Invalid variable-length integer length ("
+                  << static_cast<int>(bytes) << ") encountered.\n";
         return 0;
     }
+
+    return length;
 }
 
 void Xdf::findMinMax()
@@ -781,7 +741,7 @@ void Xdf::findMinMax()
     //find the smallest timestamp of all streams
     for (auto const &stream : streams)
     {
-        if (stream.info.first_timestamp != -1)
+        if (!std::isnan(stream.info.first_timestamp))
         {
             minTS = stream.info.first_timestamp;
             break;
@@ -789,14 +749,14 @@ void Xdf::findMinMax()
     }
     for (auto const &stream : streams)
     {
-        if (stream.info.first_timestamp != -1 && stream.info.first_timestamp < minTS)
+        if (!std::isnan(stream.info.first_timestamp) && stream.info.first_timestamp < minTS)
             minTS = stream.info.first_timestamp;
     }
 
     //find the max timestamp of all streams
     for (auto const &stream : streams)
     {
-        if (stream.info.last_timestamp != 0 && stream.info.last_timestamp > maxTS)
+        if (!std::isnan(stream.info.last_timestamp) && stream.info.last_timestamp > maxTS)
             maxTS = stream.info.last_timestamp;
     }
 }
@@ -915,7 +875,7 @@ void Xdf::detrend()
         {
             long double init = 0.0;
             long double mean = std::accumulate(row.begin(), row.end(), init) / row.size();
-            std::transform(row.begin(), row.end(), row.begin(), bind2nd(std::minus<double>(), mean));
+	    for(auto &val: row) val -= mean;
             offsets.emplace_back(mean);
         }
     }
@@ -1126,3 +1086,10 @@ void Xdf::loadDictionary()
             eventType.emplace_back(std::distance(dictionary.begin(), it));
     }
 }
+
+template<typename T> T Xdf::readBin(std::istream& is, T* obj) {
+	T dummy;
+	if(!obj) obj = &dummy;
+	is.read(reinterpret_cast<char*>(obj), sizeof(T));
+	return *obj;
+}


=====================================
xdf.h
=====================================
@@ -297,6 +297,20 @@ private:
      * \return The length of the upcoming chunk (in bytes).
      */
     uint64_t readLength(std::ifstream &file);
+
+	/*!
+     * \brief Read a binary scalar variable from an input stream.
+     *
+     * readBin is a convenience wrapper for the common
+     * file.read((char*) var, sizeof(var))
+     * operation. Examples:
+     * double foo = readBin<double>(file); // use return value
+     * readBin(file, &foo); // read directly into foo
+     * \param is an input stream to read from
+     * \param obj pointer to a variable to load the data into or nullptr
+     * \return the read data
+     */
+    template<typename T> T readBin(std::istream& is, T* obj = nullptr);
 };
 
 #endif // XDF_H


=====================================
xdf.pro
=====================================
@@ -3,6 +3,7 @@ QT -= gui
 TARGET = xdf
 TEMPLATE = lib
 CONFIG += c++11 shared_and_static build_all
+INCLUDEPATH += pugixml
 
 QMAKE_CFLAGS += -std=c99
 



View it on GitLab: https://salsa.debian.org/med-team/libxdf/-/compare/d9e21947c9050b1377a0ff7acdc55cc1fa401e63...7825557ce7457596c840540a9737fa442436d836

-- 
View it on GitLab: https://salsa.debian.org/med-team/libxdf/-/compare/d9e21947c9050b1377a0ff7acdc55cc1fa401e63...7825557ce7457596c840540a9737fa442436d836
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20201218/32b52f7a/attachment-0001.html>


More information about the debian-med-commit mailing list