[med-svn] [Git][med-team/ncbi-blastplus][master] change optout to optin strategy for usage reports sent over internet Closes #1005279

[Olivier Sallou (@osallou)]

Olivier Sallou pushed to branch master at Debian Med / ncbi-blastplus


Commits:
84e9a187 by Olivier Sallou at 2022-02-10T13:02:15+00:00
change optout to optin strategy for usage reports sent over internet Closes #1005279

- - - - -


3 changed files:

- debian/changelog
- + debian/patches/optin_usage_report
- debian/patches/series


Changes:

=====================================
debian/changelog
=====================================
@@ -1,3 +1,11 @@
+ncbi-blast+ (2.12.0+ds-3) unstable; urgency=medium
+
+  * d/patches/optin_usage_report change usage reports sending over
+    internet strategy to optin (disabled by default unless specified) 
+    (Closes # 1005279).
+
+ -- Olivier Sallou <osallou at debian.org>  Thu, 10 Feb 2022 12:17:56 +0000
+
 ncbi-blast+ (2.12.0+ds-2) unstable; urgency=medium
 
   * Clean up spurious release-status comment from 2.12.0+ds-1.


=====================================
debian/patches/optin_usage_report
=====================================
@@ -0,0 +1,47 @@
+Subject: blast+ use optout to send usage reports over internet
+Description: this patch change strategy to optin ie user asks
+ per config/env vars to send reports, else it is disabled by default.
+ Not a bug by itself but default strategy update to send info over internet.
+Author: Olivier Sallou <osallou at debian.org>
+Last-Updated: 202-02-10
+Forwarded: no
+--- a/c++/src/algo/blast/api/blast_usage_report.cpp
++++ b/c++/src/algo/blast/api/blast_usage_report.cpp
+@@ -184,6 +184,7 @@
+ void CBlastUsageReport::x_CheckBlastUsageEnv()
+ {
+ 	char * blast_usage_env = getenv("BLAST_USAGE_REPORT");
++
+ 	if(blast_usage_env != NULL){
+ 		bool enable = NStr::StringToBool(blast_usage_env);
+ 		if (!enable) {
+@@ -192,6 +193,10 @@
+ 			LOG_POST(Info <<"Phone home disabled");
+ 			return ;
+ 		}
++                SetEnabled(true);
++                CUsageReportAPI::SetEnabled(true);
++                LOG_POST(Info <<"Phone home enabled");
++                return;
+ 	}
+ 
+ 	CNcbiIstrstream empty_stream(kEmptyCStr);
+@@ -204,10 +209,15 @@
+ 			LOG_POST(Info <<"Phone home disabled by config setting");
+ 			return ;
+ 		}
++                SetEnabled(true);
++                CUsageReportAPI::SetEnabled(true);
++                LOG_POST(Info <<"Phone home enabled by config setting");
++                return ;
+ 	}
+-	CUsageReportAPI::SetEnabled(true);
+-	SetEnabled(true);
+-	LOG_POST(Info <<"Phone home enabled");
++        // Debian optin by default (do not send reports)
++	CUsageReportAPI::SetEnabled(false);
++	SetEnabled(false);
++	LOG_POST(Info <<"Phone home disabled");
+ }
+ 
+ void CBlastUsageReport::AddParam(EUsageParams p, Int8 val)


=====================================
debian/patches/series
=====================================
@@ -1,3 +1,4 @@
+optin_usage_report
 enable_clean_after_failed_compile
 hurd_fixes
 legacy_rename_rpsblast



View it on GitLab: https://salsa.debian.org/med-team/ncbi-blastplus/-/commit/84e9a187b0f9a95f292c9a640ec20509e02d4c14

-- 
View it on GitLab: https://salsa.debian.org/med-team/ncbi-blastplus/-/commit/84e9a187b0f9a95f292c9a640ec20509e02d4c14
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20220210/4fea3624/attachment-0001.htm>