[med-svn] [Git][med-team/arb][master] 3 commits: 111_fgets.patch: never use gets(3).

[Étienne Mollier (@emollier)]

Étienne Mollier pushed to branch master at Debian Med / arb


Commits:
e4d631a1 by Étienne Mollier at 2024-08-24T12:25:42+02:00
111_fgets.patch: never use gets(3).

- - - - -
53986e8a by Étienne Mollier at 2024-08-24T12:26:11+02:00
d/rules: workaround code unfit for gcc 14.

Closes: #1078136

- - - - -
fb05b2e8 by Étienne Mollier at 2024-08-24T12:28:41+02:00
Ready for upload to unstable.

- - - - -


4 changed files:

- debian/changelog
- + debian/patches/111_fgets.patch
- debian/patches/series
- debian/rules


Changes:

=====================================
debian/changelog
=====================================
@@ -1,3 +1,11 @@
+arb (6.0.6-8) unstable; urgency=medium
+
+  * Team upload.
+  * 111_fgets.patch: never use gets(3).
+  * d/rules: workaround code unfit for gcc 14. (Closes: #1078136)
+
+ -- Étienne Mollier <emollier at debian.org>  Sat, 24 Aug 2024 12:27:15 +0200
+
 arb (6.0.6-7) unstable; urgency=medium
 
   * Team upload.


=====================================
debian/patches/111_fgets.patch
=====================================
@@ -0,0 +1,37 @@
+Description: never use gets(3).
+ This patch changes gets(3) calls for fgets(3) invocations instead.
+
+Author: Étienne Mollier <emollier at debian.org>
+Forwarded: no
+Last-Update: 2024-08-24
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- arb.orig/GDE/CLUSTAL/amenu.c
++++ arb/GDE/CLUSTAL/amenu.c
+@@ -1451,7 +1451,7 @@
+ 
+ 	if(usemenu) {
+ 		fprintf(stdout,local_prompt,file_name);
+-		gets(temp);
++		fgets(temp, FILENAMELEN+1, stdin);
+ 		if(*temp != EOS) strcpy(file_name,temp);
+ 	}
+ 
+@@ -1557,7 +1557,7 @@
+ 	strcat(treename,"dnd");
+ 	
+ 	fprintf(stdout,"\nEnter a name for the DENDROGRAM file [%s]: ",treename);
+-	gets(temp);
++	fgets(temp, FILENAMELEN+1, stdin);
+ 	if(*temp != EOS)
+ 		strcpy(treename,temp);
+ 	
+@@ -1617,7 +1617,7 @@
+ 	strcat(treename,"dnd");
+ 	
+ 	fprintf(stdout,"\nEnter a name for the DENDROGRAM file      [%s]:",treename);
+-	gets(temp);
++	fgets(temp, MAXLINE+1, stdin);
+ 	if(*temp != EOS)
+ 		strcpy(treename,temp);
+ 	


=====================================
debian/patches/series
=====================================
@@ -9,3 +9,4 @@
 90_do_not_create_MAFFT_symlinks.patch
 100_use_tirpc.patch
 110_narrowing.patch
+111_fgets.patch


=====================================
debian/rules
=====================================
@@ -27,6 +27,14 @@ LC_ALL := C
 export ARBHOME LD_LIBRARY_PATH PATH LC_ALL
 export DEB_CXXFLAGS_MAINT_APPEND=-std=c++98
 
+# Workarounds to multiple build failures with gcc 14 in arb, which would
+# require extensive rewrite to fix properly, notably the implicit
+# function declarations that would normally be fixed with proper header
+# files.
+export DEB_CFLAGS_MAINT_APPEND=\
+	-Wno-error=implicit-int \
+	-Wno-error=implicit-function-declaration
+
 %:
 	dh $@
 



View it on GitLab: https://salsa.debian.org/med-team/arb/-/compare/f2277d93d55a9641f890804b0e8b6b6afd31110a...fb05b2e890e2650e6eb1055a60c025448b325c75

-- 
View it on GitLab: https://salsa.debian.org/med-team/arb/-/compare/f2277d93d55a9641f890804b0e8b6b6afd31110a...fb05b2e890e2650e6eb1055a60c025448b325c75
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20240824/aae59e7d/attachment-0001.htm>