[med-svn] [Git][med-team/python-hmmlearn][master] 3 commits: use the random_state passed to make_covar_matrix() for tied covariances as...
Andreas Tille (@tille)
gitlab at salsa.debian.org
Thu Oct 29 16:39:58 GMT 2026
Andreas Tille pushed to branch master at Debian Med / python-hmmlearn
Commits:
eef772dd by Andreas Tille at 2026-10-29T17:32:50+01:00
use the random_state passed to make_covar_matrix() for tied covariances as well; without it the test data came from the global NumPy RNG, which made TestGaussianHMMWithTiedCovars fail on some seeds
- - - - -
43248d83 by Andreas Tille at 2026-10-29T17:33:05+01:00
d/rules: only run the test suite for the default Python, since python3-sklearn is built for the default Python only.
- - - - -
d237520f by Andreas Tille at 2026-10-29T17:38:11+01:00
Upload to unstable
- - - - -
4 changed files:
- debian/changelog
- + debian/patches/series
- + debian/patches/tied-make-covar-matrix-random-state.patch
- debian/rules
Changes:
=====================================
debian/changelog
=====================================
@@ -1,4 +1,4 @@
-python-hmmlearn (0.3.3-2) UNRELEASED; urgency=medium
+python-hmmlearn (0.3.3-2) unstable; urgency=medium
[ Michael R. Crusoe ]
* d/rules: test invocation: match upstream including the test inside
@@ -8,8 +8,14 @@ python-hmmlearn (0.3.3-2) UNRELEASED; urgency=medium
[ Andreas Tille ]
* Standards-Version: 4.7.4 (routine-update)
* Reflow Uploaders field (cme)
-
- -- Michael R. Crusoe <crusoe at debian.org> Fri, 27 Mar 2026 12:15:28 +0200
+ * d/patches: use the random_state passed to make_covar_matrix() for tied
+ covariances as well; without it the test data came from the global NumPy
+ RNG, which made TestGaussianHMMWithTiedCovars fail on some seeds
+ (Closes: #1129897).
+ * d/rules: only run the test suite for the default Python, since
+ python3-sklearn is built for the default Python only.
+
+ -- Andreas Tille <tille at debian.org> Thu, 29 Oct 2026 17:33:48 +0100
python-hmmlearn (0.3.3-1) unstable; urgency=medium
=====================================
debian/patches/series
=====================================
@@ -0,0 +1 @@
+tied-make-covar-matrix-random-state.patch
=====================================
debian/patches/tied-make-covar-matrix-random-state.patch
=====================================
@@ -0,0 +1,22 @@
+Description: use the given random_state for tied covariance matrices
+ make_covar_matrix() ignored its random_state argument for
+ covariance_type == 'tied' because make_spd_matrix() was called without it.
+ The matrix was therefore drawn from the global NumPy RNG, so the test data
+ of TestGaussianHMMWithTiedCovars depended on the seed picked in
+ conftest.py and test_fit_with_priors failed on some of them.
+Origin: https://github.com/hmmlearn/hmmlearn/issues/580
+Bug-Debian: https://bugs.debian.org/1129897
+Forwarded: https://github.com/hmmlearn/hmmlearn/issues/580
+Last-Update: 2026-10-29
+---
+--- a/src/hmmlearn/tests/__init__.py
++++ b/src/hmmlearn/tests/__init__.py
+@@ -19,7 +19,7 @@
+ if covariance_type == 'spherical':
+ return (mincv + mincv * prng.random_sample((n_components,))) ** 2
+ elif covariance_type == 'tied':
+- return (make_spd_matrix(n_features)
++ return (make_spd_matrix(n_features, random_state=prng)
+ + mincv * np.eye(n_features))
+ elif covariance_type == 'diag':
+ return (mincv + mincv *
=====================================
debian/rules
=====================================
@@ -6,5 +6,10 @@ export PYBUILD_NAME=hmmlearn
export PYBUILD_TEST_ARGS={dir}/doc --pyargs hmmlearn.tests
export PYBUILD_AFTER_TEST=find . -name filename.pkl -delete
+# python3-sklearn ships ext modules for the default Python only, so the test
+# suite cannot run on the other supported versions.
+export PYBUILD_DISABLE = $(addprefix test/,$(filter-out \
+ $(shell py3versions -d),$(shell py3versions -r)))
+
%:
dh $@ --buildsystem=pybuild
View it on GitLab: https://salsa.debian.org/med-team/python-hmmlearn/-/compare/fa8f78d45dee9c0c46104ce2d8d0761fe08c2809...d237520f95606468469daf827f4bba2d031a255a
--
View it on GitLab: https://salsa.debian.org/med-team/python-hmmlearn/-/compare/fa8f78d45dee9c0c46104ce2d8d0761fe08c2809...d237520f95606468469daf827f4bba2d031a255a
You're receiving this email because of your account on salsa.debian.org. Manage all notifications: https://salsa.debian.org/-/profile/notifications | Help: https://salsa.debian.org/help
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-med-commit/attachments/20261029/174ae450/attachment-0001.htm>
More information about the debian-med-commit
mailing list