[Debian-med-packaging] Bug#417482: FTBFS with GCC 4.3: missing #includes

[Martin Michlmayr]

Package: probcons
Version: 1.11-1
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In GCC 4.3, the C++ header
dependencies have been cleaned up.  The advantage of this is that
programs will compile faster.  The downside is that you actually
need to directly #include everything you use (but you really should
do this anyway, otherwise your program won't work with any compiler
other than GCC).  Some background of this can be found at
http://gcc.gnu.org/PR28080

You can reproduce this problem with gcc-snapshot (20070326-1 or higher)
from unstable.

> Automatic build of probcons_1.11-1 on em64t by sbuild/amd64 0.53
...
> g++ -O3 -W -Wall -pedantic -DNDEBUG -DNumInsertStates=2 -DVERSION="1.11" -funroll-loops -lm -o probcons Main.cc 
> In file included from Main.cc:11:
> ProbabilisticModel.h: In member function 'void ProbabilisticModel::ComputeNewParameters(Sequence*, Sequence*, const VF&, const VF&, VF&, VF&, VF&, VVF&, VF&, bool) const':
> ProbabilisticModel.h:492: warning: suggest parentheses around && within ||
> Main.cc: In function 'bool GetInteger(char*, int*)':
> Main.cc:547: error: 'LONG_MAX' was not declared in this scope
> Main.cc:547: error: 'LONG_MIN' was not declared in this scope
> Main.cc:548: error: 'INT_MIN' was not declared in this scope
> Main.cc:548: error: 'INT_MAX' was not declared in this scope
> make[1]: *** [probcons] Error 1

--- Main.cc~	2007-04-02 21:12:48.000000000 +0000
+++ Main.cc	2007-04-02 21:12:58.000000000 +0000
@@ -18,6 +18,7 @@
 #include <list>
 #include <set>
 #include <algorithm>
+#include <climits>
 #include <cstdio>
 #include <cstdlib>
 #include <cerrno>
--- Main-RNA.cc~	2007-04-02 21:13:49.000000000 +0000
+++ Main-RNA.cc	2007-04-02 21:13:56.000000000 +0000
@@ -18,6 +18,7 @@
 #include <list>
 #include <set>
 #include <algorithm>
+#include <climits>
 #include <cstdio>
 #include <cstdlib>
 #include <cerrno>
--- MakeGnuPlot.cc~	2007-04-02 21:15:34.000000000 +0000
+++ MakeGnuPlot.cc	2007-04-02 21:15:39.000000000 +0000
@@ -2,6 +2,7 @@
 // MakeGnuPlot.cc
 /////////////////////////////////////////////////////////////////
 
+#include <cstdlib>
 #include <iostream>
 #include <fstream>
 

-- 
Martin Michlmayr
http://www.cyrius.com/