[Debian-med-packaging] [arb] Bug in makefile.patch

[Marek Stopka]

Hi, in file http://ftp.de.debian.org/debian/pool/non-free/a/arb/arb_0.0.20071207.1-5.diff.gz

there is this diff

1436 --- arb-0.0.20071207.1.orig/debian/patches/30_Makefile_main
1437 +++ arb-0.0.20071207.1/debian/patches/30_Makefile_main
1438 @@ -0,0 +1,28 @@
1439 +--- arb-0.0.20071207.1.orig/Makefile
1440 ++++ arb-0.0.20071207.1/Makefile
1441 +@@ -76,7 +76,7 @@
1442 + #   cflags = -O2 $(dflag1) $(dflags) $(DEVEL_DEF)
1443 + #   cflags = -O4 $(dflag1) $(dflags) $(DEVEL_DEF)
1444 +
1445 +-    lflags = $(dflag1)
1446 ++    lflags = $(dflag1) $(lflags)
1447 +     fflags = $(dflag1) -C
1448 +     extended_warnings         = -Wwrite-strings -Wunused
-Wno-aggregate-return -Wshadow
1449 +     extended_cpp_warnings     = -Wnon-virtual-dtor -Wreorder
-Wpointer-arith
1450 +@@ -109,7 +109,7 @@
1451 +
1452 + ALLOWED_GCC_295_VERSIONS=2.95.3
1453 + ALLOWED_GCC_3xx_VERSIONS=3.2 3.3.1 3.3.3 3.3.4 3.3.5 3.3.6
3.4.0 3.4.2 3.4.3
1454 +-ALLOWED_GCC_4xx_VERSIONS=4.0.0 4.0.2 4.0.3 4.1.1 4.1.2 4.1.3
4.2.0 4.2.1 4.2.3
1455 ++ALLOWED_GCC_4xx_VERSIONS=4.0.0 4.0.2 4.0.3 4.1.1 4.1.2 4.1.3
4.2.0 4.2.1 4.2.3 4.3.1 4.3.2 4.3.3
1456 + ALLOWED_GCC_VERSIONS=$(ALLOWED_GCC_295_VERSIONS)
$(ALLOWED_GCC_3xx_VERSIONS) $(ALLOWED_GCC_4xx_VERSIONS)
1457 +
1458 + GCC_VERSION_FOUND=$(shell $(GCC) -dumpversion)
1459 +@@ -133,6 +133,7 @@
1460 +
1461 + ifdef DEBIAN
1462 +    XHOME = /usr/X11R6
1463 ++   lflags = -Wl,-rpath,/usr/lib/arb/lib
1464 + else
1465 +    XHOME = /usr/X11
1466 + endif

but that line
1446 ++    lflags = $(dflag1) $(lflags)
is a nonsense. Because when you activate debug option (after applying
this patch) make all will return you

make arbbasic2
make[1]: Entering directory `/usr/src/packages/BUILD/arb-2007_12_07'
Makefile:79: *** Recursive variable `lflags' references itself
(eventually).  Stop.
make[1]: Leaving directory `/usr/src/packages/BUILD/arb-2007_12_07'
make: *** [arbbasic] Error 2

But nice work with that other patches... I is really helpful for me
when I am working on openSUSE package of this program.

-- 
S pozdravem / Best regards
Marek Stopka
Official openSUSE community member
Kontakty / Contacts
Mobil/Cell phone: 774 59 79 40
E-mail: mstopka at opensuse.org
WEB: www.m4r3k.org