[Debian-med-packaging] [arb] Bug in makefile.patch

[Andreas Tille]

On Sun, 12 Oct 2008, Marek Stopka wrote:

> Hi, in file http://ftp.de.debian.org/debian/pool/non-free/a/arb/arb_0.0.20071207.1-5.diff.gz
>
> there is this diff
>
> 1436 --- arb-0.0.20071207.1.orig/debian/patches/30_Makefile_main
> 1437 +++ arb-0.0.20071207.1/debian/patches/30_Makefile_main
> 1438 @@ -0,0 +1,28 @@
> 1439 +--- arb-0.0.20071207.1.orig/Makefile
> 1440 ++++ arb-0.0.20071207.1/Makefile
> 1441 +@@ -76,7 +76,7 @@
> 1442 + #   cflags = -O2 $(dflag1) $(dflags) $(DEVEL_DEF)
> 1443 + #   cflags = -O4 $(dflag1) $(dflags) $(DEVEL_DEF)
> 1444 +
> 1445 +-    lflags = $(dflag1)
> 1446 ++    lflags = $(dflag1) $(lflags)
> 1447 +     fflags = $(dflag1) -C
> 1448 +     extended_warnings         = -Wwrite-strings -Wunused
> -Wno-aggregate-return -Wshadow
> 1449 +     extended_cpp_warnings     = -Wnon-virtual-dtor -Wreorder
> -Wpointer-arith
> 1450 +@@ -109,7 +109,7 @@
> 1451 +
> 1452 + ALLOWED_GCC_295_VERSIONS=2.95.3
> 1453 + ALLOWED_GCC_3xx_VERSIONS=3.2 3.3.1 3.3.3 3.3.4 3.3.5 3.3.6
> 3.4.0 3.4.2 3.4.3
> 1454 +-ALLOWED_GCC_4xx_VERSIONS=4.0.0 4.0.2 4.0.3 4.1.1 4.1.2 4.1.3
> 4.2.0 4.2.1 4.2.3
> 1455 ++ALLOWED_GCC_4xx_VERSIONS=4.0.0 4.0.2 4.0.3 4.1.1 4.1.2 4.1.3
> 4.2.0 4.2.1 4.2.3 4.3.1 4.3.2 4.3.3
> 1456 + ALLOWED_GCC_VERSIONS=$(ALLOWED_GCC_295_VERSIONS)
> $(ALLOWED_GCC_3xx_VERSIONS) $(ALLOWED_GCC_4xx_VERSIONS)
> 1457 +
> 1458 + GCC_VERSION_FOUND=$(shell $(GCC) -dumpversion)
> 1459 +@@ -133,6 +133,7 @@
> 1460 +
> 1461 + ifdef DEBIAN
> 1462 +    XHOME = /usr/X11R6
> 1463 ++   lflags = -Wl,-rpath,/usr/lib/arb/lib
> 1464 + else
> 1465 +    XHOME = /usr/X11
> 1466 + endif
>
> but that line
> 1446 ++    lflags = $(dflag1) $(lflags)
> is a nonsense. Because when you activate debug option (after applying
> this patch) make all will return you

It had lasted longer than expected until I was able to work on arb again.
Could you please tell me what actual command line you are using which causes
the problem?

I can not really reproduce what might cause the error.

BTW, you might be interested in

    http://svn.debian.org/wsvn/debian-med/trunk/packages/arb/trunk/debian/patches/tmpfile_CVE-2008-5378.patch?op=file&rev=0&sc=0

Kind regards and thanks for your patience

       Andreas.

-- 
http://fam-tille.de