[Debian-med-packaging] Bug#536676: plink: FTBFS on MIPS.

[Charles Plessy]

Package: plink
Version: 1.06-1
Severity: serious
Justification: no longer builds from source

thanks


Le Sat, Jul 11, 2009 at 12:06:21PM +0200, Luk Claes a écrit :
> Charles Plessy wrote:
> > Le Fri, Jul 10, 2009 at 08:56:31PM +0000, DDPOMail robot a écrit :
> >> === plink:
> >> = Missing build(s) on mips,mipsel
> >>   This might need manual action from your side.
> >>   See http://buildd.debian.org/pkg.cgi?pkg=plink
> > 
> > Dear MIPS porters,
> > 
> > any idea of what makes plink fail to build on mips and mipsel?
> 
> Seems to be a bug in the compiler from a first look, lets see if a retry
> still fails.

Thank you very much for the rebuild. It reproduced the bug :(

How about trying to separate the issues of having a bug in GCC and having a
package that does not build on MIPS? I noticed that the package is built with
-O3, which probably unnecessary. Can somebody try to build plink with -O2 on
MIPS to see if it escapes the bug? The following patch in debian/rules would to
the job: 

--- ../plink/debian/rules	2009-07-12 18:59:28.000000000 +0900
+++ plink-1.06/debian/rules	2009-07-12 19:21:28.000000000 +0900
@@ -5,9 +5,33 @@
 
 pkg=plink
 
+# DEB_BUILD_OPTIONS from Policy § 4.9.1
+CXXFLAGS = -Wall -g
+INSTALL = install
+INSTALL_FILE    = $(INSTALL) -p    -o root -g root  -m  644
+INSTALL_PROGRAM = $(INSTALL) -p    -o root -g root  -m  755
+INSTALL_SCRIPT  = $(INSTALL) -p    -o root -g root  -m  755
+INSTALL_DIR     = $(INSTALL) -p -d -o root -g root  -m  755
+
+ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
+    CXXFLAGS += -O0
+else
+    CXXFLAGS += -O2
+endif
+ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
+    INSTALL_PROGRAM += -s
+endif
+ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
+    NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
+    MAKEFLAGS += -j$(NUMJOBS)
+endif
+
+# This would be added by Upstream makefile, but we override CXXFLAGS…
+CXXFLAGS += -DUNIX -DWITH_R_PLUGINS
+
 build: patch build-stamp
 build-stamp:
-	$(MAKE) CXX_UNIX=g++ WITH_R_PLUGINS=1
+	$(MAKE) CXXFLAGS='$(CXXFLAGS)'
 	touch $@
 
 clean: unpatch


If it builds with -O2, we can upload a corrected package, and you can forward
this bug on GCC if you think it is worth (which I can not judge).

Have a nice day,

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan