[Debian-med-packaging] Bug#532396: FTBFS with GCC 4.4: missing #include

[Martin Michlmayr]

Package: sofa-framework
Version: 1.0~beta4-1
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.4
Tags: patch

Your package fails to build with GCC 4.4, which has cleaned up some more
C++ headers.  You always have to #include headers directly and cannot
rely for things to be included indirectly.

You can reproduce this problem with gcc-4.4/g++-4.4 from unstable.

It seems the patch from #505953 got lost.  Below is a new patch but
I'm not sure it's complete because I run into this compile problem:
| RealGUI.h:40:17: error: GUI.h: No such file or directory


> Automatic build of sofa-framework_1.0~beta4-1 on em64t by sbuild/amd64 0.53
...
> g++ -c -pipe -W -I/usr/include/libxml2 -O2 -D_REENTRANT -fPIC -DSOFA_QT4 -DSOFA_GUI_QTVIEWER -DSOFA_GUI_GLUT -DSOFA_HAVE_PNG -DSOFA_HAVE_GLEW -DSOFA_HAVE_BOOST -DSOFA_PML -DSOFA_SUPPORT_MOVING_FRAMES -DDUMP_VISITOR_INFO -DSOFA_HAVE_CSPARSE -DNDEBUG -DSOFA_XML_PARSER_TINYXML -DMINI_FLOWVR -DSOFA_BUILD_HELPER -I/usr/share/qt4/mkspecs/linux-g++ -I. -I../../../include -I../../../framework -I/usr/include/qt4 -I/usr/include/qwt-qt4 -I../../../extlibs/csparse -I../../../extlibs/tinyxml -I/usr/include/libxml2 -I../../../extlibs/PML -I../../../extlibs/PML/PhysicalProperties -I../../../extlibs/LML -I../../../extlibs/miniFlowVR/include -I/usr/include/libxml2 -o OBJ/release/Capture.o gl/Capture.cpp
> gl/Capture.cpp: In member function 'std::string sofa::helper::gl::Capture::findFilename()':
> gl/Capture.cpp:80: error: 'sprintf' was not declared in this scope
> gl/Capture.cpp:92: error: 'sprintf' was not declared in this scope
> make[4]: *** [OBJ/release/Capture.o] Error 1
> make[4]: Leaving directory `/build/tbm/sofa-framework-1.0~beta4/framework/sofa/helper'
> make[3]: *** [sub-helper-make_default-ordered] Error 2

--- framework/sofa/helper/io/ImageBMP.cpp~	2009-06-08 21:02:07.000000000 +0000
+++ framework/sofa/helper/io/ImageBMP.cpp	2009-06-08 21:02:17.000000000 +0000
@@ -26,6 +26,7 @@
 ******************************************************************************/
 #include <sofa/helper/io/ImageBMP.h>
 #include <sofa/helper/system/FileRepository.h>
+#include <cstdio>
 #include <iostream>
 
 namespace sofa
--- framework/sofa/helper/io/ImageRAW.cpp~	2009-06-08 21:02:31.000000000 +0000
+++ framework/sofa/helper/io/ImageRAW.cpp	2009-06-08 21:02:49.000000000 +0000
@@ -26,6 +26,7 @@
 ******************************************************************************/
 #include <sofa/helper/io/ImageRAW.h>
 #include <sofa/helper/system/FileRepository.h>
+#include <cstdio>
 #include <iostream>
 
 namespace sofa
--- framework/sofa/helper/io/MeshTrian.cpp~	2009-06-08 21:04:01.000000000 +0000
+++ framework/sofa/helper/io/MeshTrian.cpp	2009-06-08 21:04:12.000000000 +0000
@@ -26,6 +26,7 @@
 ******************************************************************************/
 #include <sofa/helper/io/MeshTrian.h>
 #include <sofa/helper/system/FileRepository.h>
+#include <stdio.h>
 #include <stdlib.h>
 #include <iostream>
 #include <string>
--- framework/sofa/helper/gl/Capture.cpp~	2009-06-08 21:01:16.000000000 +0000
+++ framework/sofa/helper/gl/Capture.cpp	2009-06-08 21:01:54.000000000 +0000
@@ -30,6 +30,7 @@
 #include <sofa/helper/io/ImagePNG.h>
 #endif
 
+#include <cstdio>
 #include <sys/types.h>
 #include <sys/stat.h>
 
--- framework/sofa/helper/Quater.inl~	2009-06-08 21:18:51.000000000 +0000
+++ framework/sofa/helper/Quater.inl	2009-06-08 21:18:57.000000000 +0000
@@ -29,6 +29,7 @@
 
 #include "Quater.h"
 #include <math.h>
+#include <cstdio>
 #include <iostream>
 
 namespace sofa
--- framework/sofa/helper/LCPSolver.inl~	2009-06-08 21:27:35.000000000 +0000
+++ framework/sofa/helper/LCPSolver.inl	2009-06-08 21:27:43.000000000 +0000
@@ -28,6 +28,7 @@
 #define SOFA_HELPER_LCPSOLVER_INL
 
 #include <sofa/helper/LCPSolver.h>
+#include <cstdio>
 
 namespace sofa
 {

-- 
Martin Michlmayr
http://www.cyrius.com/