[Debian-med-packaging] Bug#642094: gdpc: uses functions deprecated in current GDK but builds with -DGDK_DISABLE_DEPRECATED

[Colin Watson]

Package: gdpc
Version: 2.2.5-1
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch oneiric

As reported in this Ubuntu bug:

  https://bugs.launchpad.net/ubuntu/+source/gdpc/+bug/770768

... gdpc uses GDK drawing functions which have been deprecated since GDK
2.22 in favour of Cairo.  It compiles with the various
*_DISABLE_DEPRECATED options, which are intended to help maintainers
port to newer versions of the libraries and should not generally be set
in release builds.  As a result, it may break on 64-bit architectures
due to the implicit conversion to int:

  http://wiki.debian.org/ImplicitPointerConversions

The following patch removes -DGDK_DISABLE_DEPRECATED.  A full port to
Cairo would of course be better but is more effort; but in any case
*_DISABLE_DEPRECATED outside maintainer builds just makes it harder to
produce a buildable Debian archive so it's still worth dropping it.

  * Drop -DGDK_DISABLE_DEPRECATED until such time as gdpc is converted to
    use Cairo for drawing (LP: #770768).

diff -u gdpc-2.2.5/debian/patches/series gdpc-2.2.5/debian/patches/series
--- gdpc-2.2.5/debian/patches/series
+++ gdpc-2.2.5/debian/patches/series
@@ -1,0 +2 @@
+30_gdk_enable_deprecated.patch
only in patch2:
unchanged:
--- gdpc-2.2.5.orig/debian/patches/30_gdk_enable_deprecated.patch
+++ gdpc-2.2.5/debian/patches/30_gdk_enable_deprecated.patch
@@ -0,0 +1,20 @@
+Description: Drop -DGDK_DISABLE_DEPRECATED
+ gdpc uses GDK drawing functions, and needs to be converted to use Cairo
+ instead.  In the meantime, -DGDK_DISABLE_DEPRECATED unhelpfully breaks
+ prototypes in release builds, so drop it.
+Author: Colin Watson <cjwatson at ubuntu.com>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/770768
+Forwarded: no
+Last-Update: 2011-09-19
+
+Index: b/Makefile
+===================================================================
+--- a/Makefile
++++ b/Makefile
+@@ -1,5 +1,5 @@
+ CC = gcc
+-FLAGS=$(CFLAGS) -g -Wall `pkg-config --cflags gtk+-2.0 gthread-2.0` -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
++FLAGS=$(CFLAGS) -g -Wall `pkg-config --cflags gtk+-2.0 gthread-2.0` -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED
+ LIBS=`pkg-config --libs gtk+-2.0 gthread-2.0`
+ bindir ?= /usr/bin
+ 

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]