[Debian-med-packaging] Bug#670759: tabix: LDFLAGS hardening flags missing

[Simon Ruderich]

Package: tabix
Version: 0.2.5-2
Severity: important
Tags: patch

Dear Maintainer,

The LDFLAGS hardening flags are missing because the build system
ignores them. For more hardening information please have a look
at [1], [2] and [3].

The attached patch is a revised version of
use-dpkg-buildflags.patch which fixes the issue. If possible it
should be sent to upstream.

It also fixes the usage of the *FLAGS variables. CFLAGS/CXXFLAGS
are compiler flags for C/C++ files, CPPFLAGS are preprocessor
flags (gcc -E), LDFLAGS are linker flags (there are some cases
where the compiler generates code when linking, thus CFLAGS are
also used when linking just to be sure).

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log (for example with blhc [4]) (hardening-check
doesn't catch everything):

    $ hardening-check /usr/bin/bgzip /usr/bin/tabix
    /usr/bin/bgzip:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!
    /usr/bin/tabix:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
[4]: http://ruderich.org/simon/blhc/
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use-dpkg-buildflags.patch
Type: text/x-diff
Size: 1647 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20120428/d7fb13a3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20120428/d7fb13a3/attachment.pgp>