[Debian-med-packaging] r11969 - in trunk/packages/treeviewx/trunk/debian: . patches source

[Tim Booth]

Hi Andreas,

Thanks.  The Ubuntu world will appreciate it!

I've done a little more digging.  I tried installing the package from
Debian Wheezy straight onto Ubuntu 12.04 (amd64).  It loads the tree
without crashing but if you try to resize the window the tree doesn't
update properly (this was a second thing addressed by the patch I
added).

I get the same crash with Ubuntu treeviewx builds from 10.04 and 12.04
so I guess there must be some fundamental thing that is different in
Ubuntu to make this blow up, but I don't understand what it might be.
I'd been assuming this was some WX oddity.

I'm not a C++ programmer but I can't believe that the use of size_t(buf)
was ever right in this file.  A little test case...

tbooth at balisaur[tings]uname -a  
Linux balisaur 3.2.0-27-generic #43-Ubuntu SMP Fri Jul 6 14:25:57 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux

tbooth at balisaur[tings]cat buf.cc 
#include <iostream>

int main(void)
{
    wchar_t wbuf[256];

    std::cout << "size_t(wbuf) is " << size_t(wbuf) << ".\n";
    std::cout << "sizeof(wbuf) is " << sizeof(wbuf) << ".\n";

    return 0;
}

tbooth at balisaur[tings]g++ buf.cc -o buf ; ./buf
size_t(wbuf) is 140735454291184.
sizeof(wbuf) is 1024.

...

Erm???

TIM

On Thu, 2012-08-02 at 15:01 +0200, Andreas Tille wrote:
> Hi,
> 
> On Thu, Aug 02, 2012 at 02:02:39PM +0200, Andreas Tille wrote:
> > Hi,
> > 
> > On Thu, Aug 02, 2012 at 07:27:17PM +0900, Charles Plessy wrote:
> > > Le Thu, Aug 02, 2012 at 10:13:07AM +0000, Timothy Booth a écrit :
> > > > Log:
> > > > This is an important fix as currently treeview doesn't work at all.
> > > > 
> > > > Only tested on Ubuntu but I suggest this should be pushed to Debian as
> > > > release -3 as soon as it's tested.  Test case is simply:
> > > > 
> > > > tv /usr/share/doc/treeviewx/examples/tree.phb
> > > 
> > > Hi Tim,
> > > 
> > > on a mixed Squeeze / Wheezy system I do not experience the crash.  I will try
> > > to test it on a Sid system later.
> 
> When looking at the patch I could perfectly assume that the issue is
> arch-dependant.  Is there any information on what architecture the
> crash occures.  It does not on amd64 but it might be on i386 where
> 
>    size_t(wbuf)
> 
> could potentially be < 256 (I did not tried).
> 
> 
> > > If you want treeviewx to be patched in Wheezy, you will need:
> > > 
> > >  - A bug report that explains how to reproduce the crash, and
> > > 
> > >  - As few as possible changes between the update and 0.5.1+20100823-1.
> > >    This means reverting some of your commits in the SVN (they are very
> > >    welcome to be de-reverted later), ideally keeping only the addition
> > >    of the patch, and the changes to the series and changelog files.
> > 
> > On my quite up to date Wheezy machine the problem does not exist and
> > thus there is no point in filing an RC bug.  I'm fine with upgrading the
> > package in unstable and uploading Tim's patch after doing the very same
> > test successfully.
> 
> Tested, works, uploaded
> 
>       Andreas.
> 

-- 
If you can't find an apposite quote for your sig, just make one up.
     - Anon