[Debian-med-packaging] profbval_1.0.20-1_amd64.changes REJECTED
Laszlo Kajan
lkajan at rostlab.org
Wed Aug 8 12:37:29 UTC 2012
Dear Team, Andreas!
Please have a look at profbval and upload again if you like it.
Thank you!
Best regards,
Laszlo
On 08/08/12 14:34, Laszlo Kajan wrote:
> Dear Luca!
>
> Thank you for the comments. Find my fixes - also for norsnet - below:
>
>> - The file examples/cad23-fil.rdbProf is copyright "Burkhard Rost, CUBIC NYC /
>> LION Heidelberg", this is not mentioned in debian/copyright.
>
> It is now mentioned in d/copyright. Same problem affects norsnet, then, so could you please reject this as well for a new upload?
>
>>
>> - There is duplication of files from the package "norsnet" (also in NEW). The
>> following files are exact duplicates:
>>
>> examples/cad23-fil.rdbProf
>> examples/cad23.f
>> examples/cad23-fil.hssp
>>
>> Furthermore, both packages contain a file named scr/createDataFile.pl which
>> have very similar content.
>>
>> Only approx. 116 kB is duplicated, so maybe it is not worth creating a common
>> package for this, but it wouldn't hurt if the maintainer thinks about it.
>
> I see, indeed, thank you for pointing this out. Especially knowing about the almost identical pair of scr/createDataFile.pl is valuable
> information for me. I could do something about this upstream.
> Introducing a package for the examples: well, examples could easily change upstream. If I may, I would leave them in the packages as they are now.
>
>> - Homepage: field in debian/control points to http://rostlab.org/, but a better
>> URL is https://www.rostlab.org/owiki/index.php/PROFbval.
>
> Ok, this is corrected for both profbval and norsnet.
>
>>
>> - The long description should mention the file formats profbval works with.
>
> I added description (long overdue) upstream, and also to the long description.
>
> Best regards,
>
> Laszlo
>
>>
>> Cheers,
>> Luca
>>
>>
>>
>> ===
>>
>> Please feel free to respond to this email if you don't understand why
>> your files were rejected, or if you upload new files which address our
>> concerns.
>>
>
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
>
More information about the Debian-med-packaging
mailing list