[Debian-med-packaging] librcsb-core-wrapper read for inspection

[Andreas Tille]

Hi Lsazlo,

looks fine for me if you would drop the advise below into a file
README.Debian (or into README.test at your preference).

BTW, you patched some shell scripts to force the interpreter from
/bin/sh to /bin/bash.  This is OK in principle but the even better
solution would be to go with simple POSIX commands inside the script
and not requiring bash.  I have no idea how much interested upstream
might be in such hints - if not the simplest way to patch (as you
did ) seems to be apropriate.

Kind regards

      Andreas.

On Thu, Aug 16, 2012 at 09:07:38PM +0200, Laszlo Kajan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Dear Jakub, Andreas and whoever else would like to help me!
> 
> I am ready with librcsb-core-wrapper for inspection.
> 
> It builds cleanly for me, lintian complains but not too much, and the generated Python module does work in the test 'CorePyWrapTests.py' that
> comes with the package (that gets installed into python-librcsb-core-wrapper/examples).
> 
> Well if you want to run the test, you will need data in '..':
> 
> 0: mkdir /tmp/test && pushd /tmp/test && mkdir ../data
> 1: wget -O ../data/2j01.cif.gz http://www.rcsb.org/pdb/files/2J01.cif.gz
> 2: gunzip ../data/2j01.cif.gz
> 3: python /usr/share/doc/python-librcsb-core-wrapper/examples/CorePyWrapTests.py
> 4: popd
> 
> Please let me know what you think. Thank you in advance!
> 
> I have sent the patches upstream.
> 
> Best regards,
> 
> Laszlo
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> 
> iQIcBAEBAgAGBQJQLUT5AAoJEJvS1kCaDFL6qnkP/jRNM1esDvRTq8JlszgtBwcQ
> Vk18VcSoIknh9QrALcGah2Xa62UWlr+aaRQ8y0K/AcI5UBTICVSX0afgqBoYYwkq
> eWSBQIK2lKioPKEoehzeh+cgPQ9KiaTHly8kye23U+4QYCXZb+8WI65RTtEV6Jlk
> aJOuye1yMO+CMlC6Q3mQMxIAFj3brsUlYhnb2QHVc5d65jRdjG5uY/R9AY5FXtOu
> O2MzV6kEzKAnHDyayooaESpBY3evVhpRVkRQr+jtgfmyc4wZiFi+dSsMPNq0OJ6S
> HhRuAp/FE+jqr7t2oeaUki1fnn0un9+GLc/MvbNc4IwukfVm2CDm/pDdS7hvSxUp
> 3SuFkAQCBnMnk8DZUo8nRgUVMb2wWPGLw/r+Iy1jN2+dQlsNEXV8zwVQDlxFpetl
> l9BjLp9YnXY+vQYEvep8AxPX0I/FvlfKeJToDclarTZrYxmgnv1sdvFG6OiCLHw/
> gEW7+jMg9jcoY3mfnoJx7stnDPQlyMlGD6mJ7wOGN/f4+7BmzNzSmUKgK1A49tJa
> LgvTFYmE1eMmh6k/ksIDfRiZzY7uUCknKXpdQuWHt9G3wRXsGc8JtFnimJUcL5at
> gUWW4vDq7yFCriOwe7ytTG8Pn+nrFG17QwIwSyHRUZHDiAsgZcIw1mfgEiSydsJa
> L6JdNsxc+kd5+snOSr6X
> =6XnB
> -----END PGP SIGNATURE-----
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
> 

-- 
http://fam-tille.de