[Debian-med-packaging] r11716 - trunk/packages/norsnet/trunk/debian

[Andreas Tille]

Hi again,

additional remark:  You installed *.pl files into
/usr/share/norsnet/scr.  I had not dealt with Perl packaging a lot but
to my gut feeling this should rather be in /usr/share/perl5[/norsnet].
Did you intentionally choose this location or was it just a random
choice?  In the later case I would suggest to inspect the docs or
ask the Perl team what they would suggest.

Kind regards

       Andreas.

On Thu, Jul 12, 2012 at 02:07:29PM +0200, Andreas Tille wrote:
> Hi,
> 
> I did a review and mangled a bit in debian/upstream file.  I have one
> remaining questsion: You created a dir
> 
>     /usr/share/norsnet/example
> 
> and I wonder whether these examples are used by the code to some extend
> and thus the code might need this location.  If the examples might be
> rather user oriented they would belong to
> 
>     /usr/share/doc/norsnet/example
> 
> and you can (should) use dh_installexamples to install these files.
> 
> Kind regards
> 
>        Andreas.
> 
> On Wed, Jul 11, 2012 at 02:23:31PM +0200, Laszlo Kajan wrote:
> > Dear Christian!
> > 
> > I have reviewed norsnet and adjusted a few things (look at my commit messages). You have done a good job. I think it is ready now!
> > 
> > Andreas (or whoever feels like sponsoring):
> > 
> > * Please upload: norsnet - tool to identify unstructured loops in proteins
> > 
> > Thank you!
> > 
> > Best regards,
> > 
> > Laszlo
> > 
> > On 11/07/12 13:04, Christian Mertes wrote:
> > > again the same reply unencrypted. Sorry about that.
> > > 
> > > Hey,
> > > 
> > > thanks for the suggestion.
> > > I added my ID to the uploader field and removed the NMU.
> > > 
> > > Now i think it is done my packaging for norsnet (Bug #681108).
> > > 
> > > Kind regards
> > > Christian
> > > 
> > > 
> > > Am 11.07.2012 09:25, schrieb Andreas Tille:
> > >> On Tue, Jul 10, 2012 at 10:04:35PM +0000, Christian Mertes wrote:
> > >>> Author: mertes-guest
> > >>> Date: 2012-07-10 22:04:35 +0000 (Tue, 10 Jul 2012)
> > >>> New Revision: 11716
> > >>>
> > >>> Modified:
> > >>>    trunk/packages/norsnet/trunk/debian/changelog
> > >>> Log:
> > >>> add nmu statement to changelog
> > >> I would rather welcome if you would add your ID to the Uploaders
> > >> field rather than starting with an NMU.
> > >>
> > >> Kind regards
> > >>
> > >>        Andreas.
> > >>
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > Debian-med-packaging mailing list
> > > Debian-med-packaging at lists.alioth.debian.org
> > > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
> > > 
> > 
> > 
> > _______________________________________________
> > Debian-med-packaging mailing list
> > Debian-med-packaging at lists.alioth.debian.org
> > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
> > 
> 
> -- 
> http://fam-tille.de
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
> 

-- 
http://fam-tille.de